test: fix flaky test-webcrypto-encrypt-decrypt-aes #37380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Feb 15, 2021
This comment has been minimized.
This comment has been minimized.
* Use a copy of plaintext to prevent tampering of the original * Since subtle.decrypt returns a Promise containing an ArrayBuffer and ArrayBuffers cannot be modified directly, create a Buffer from it right away so that the modification in the next line works as intended Fixes: nodejs#35586
RaisinTen
force-pushed
the
test/fix-flaky-webcrypto-test
branch
from
be7b312
to
1af9376
Compare
|
Rebased to get a green CI. |
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
|
Landed in 4411a99 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2021
* Use a copy of plaintext to prevent tampering of the original * Since subtle.decrypt returns a Promise containing an ArrayBuffer and ArrayBuffers cannot be modified directly, create a Buffer from it right away so that the modification in the next line works as intended Fixes: #35586 PR-URL: #37380 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
* Use a copy of plaintext to prevent tampering of the original * Since subtle.decrypt returns a Promise containing an ArrayBuffer and ArrayBuffers cannot be modified directly, create a Buffer from it right away so that the modification in the next line works as intended Fixes: #35586 PR-URL: #37380 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plaintextto prevent tampering of the originalsubtle.decryptreturns aPromisecontaining anArrayBufferandArrayBuffers cannot be modified directly, create aBufferfrom itright away so that the modification in the next line works as intended
Fixes: #35586