Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-webcrypto-encrypt-decrypt-aes #37380

Closed
wants to merge 3 commits into from
Closed

test: fix flaky test-webcrypto-encrypt-decrypt-aes #37380

wants to merge 3 commits into from

Commits on Feb 17, 2021

  1. test: fix flaky test-webcrypto-encrypt-decrypt-aes 

    * Use a copy of plaintext to prevent tampering of the original
* Since subtle.decrypt returns a Promise containing an ArrayBuffer and
  ArrayBuffers cannot be modified directly, create a Buffer from it
  right away so that the modification in the next line works as intended

Fixes: nodejs#35586
    @RaisinTen
    RaisinTen committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    c8b1459 View commit details
    Browse the repository at this point in the history

  2. fixup! test: fix flaky test-webcrypto-encrypt-decrypt-aes

    @RaisinTen
    RaisinTen committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    0a0fe6f View commit details
    Browse the repository at this point in the history

  3. remove flaky test from parallel.status

    @RaisinTen
    RaisinTen committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1af9376 View commit details
    Browse the repository at this point in the history