cluster: clarify construct Handle #37385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the readability for costruct SharedHandle and RoundRobinHandle
nodejs-github-bot
added
the
cluster
marsonya
approved these changes
Feb 15, 2021
ttzztztz
approved these changes
Feb 16, 2021
Lxxyx
approved these changes
Feb 18, 2021
Lxxyx
added
the
author ready
RaisinTen
approved these changes
Feb 18, 2021
|
It seems has un-related tests failed? |
You might want to rebase again to get rid of the failure as it was fixed here: #37425 |
|
No need to rebase – Jenkins CI always rebases on top of the base branch before running the test suite, I've resumed the failing CI jobs, it should be good now. |
jasnell
approved these changes
Mar 5, 2021
|
Landed in e5a2e9a |
jasnell
pushed a commit
that referenced
this pull request
Mar 5, 2021
Improve the readability for costruct SharedHandle and RoundRobinHandle PR-URL: #37385 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Improve the readability for costruct SharedHandle and RoundRobinHandle PR-URL: #37385 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the readability for costruct SharedHandle and
RoundRobinHandle