v15.12.0 proposal #37766
Merged
v15.12.0 proposal #37766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the fsPromises readFile performance by allocating only one buffer, when size is known, increase the size of the readbuffer chunks, and dont read more data if size bytes have been read Refs: #37583 PR-URL: #37608 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
add a benchmark for fs.promises.readFile PR-URL: #37608 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #37546 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit updates the linting setup to work with eslint-plugin-markdown@2.0.0. This also allows the update-eslint script to continue to function properly without changes. PR-URL: #37549 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Many anonymous functions use the empty string as their name. Since the DEP0097 logic was using nullish coalescing, these functions were not being displayed as anonymous. This commit updates the logic to use || instead of ??. PR-URL: #37550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
The domain module monkey patches EventEmitter.prototype.emit(), however the function's name was becoming the empty string. This commit forces the new emit function to have the proper name. PR-URL: #37550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36818 Reviewed-By: Rich Trott <rtrott@gmail.com>
Iterating over arrays should be avoided because it relies on user-mutable global methods (`Array.prototype[Symbol.iterator]` and `%ArrayIteratorPrototype%.next`), we should instead use other alternatives. This commit adds a rule that disallow array destructuring syntax in favor of object destructuring syntax. Note that you can ignore this rule if you are using the array destructuring syntax over a safe iterable, or actually want to iterate over a user-provided object. PR-URL: #36818 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #37467 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #37467 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #37535 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Add `ev.ports` for spec compliancy. Since we only emit the raw `data` value, and only create the `MessageEvent` instance if there are EventTarget-style listeners, we store the ports list temporarily on the MessagePort object itself, so that we can look it up when we need to create the event object. Fixes: #37358 PR-URL: #37538 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Use a virtual function in order to save space (8 bytes per instance on 64-bit platforms) and in order to be consistent with the other methods on BaseObject. PR-URL: #37539 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Since exec calls execFile and execFile internally calls spawn with options.signal, the signal parameter has been documented under exec as well. * Refactor the description of signal under all the functions. * Add examples of usage of signal under all the functions and add missing requires in the other examples. PR-URL: #37528 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
error: comparison of integer expressions of different signedness:
‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
2562 | if (!success || std::numeric_limits<int32_t>::max() <
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
2563 | token_start_internal_value_) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
PR-URL: #37573
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #37604 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Improve the readability for costruct SharedHandle and RoundRobinHandle PR-URL: #37385 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37243 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing. PR-URL: #36610 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37077 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37590 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37606 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #37602 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37605 Refs: #37162 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
@nodejs/releasers this is ready for review! |
This comment has been minimized.
This comment has been minimized.
danielleadams
added a commit
that referenced
this pull request
Mar 17, 2021
PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486
danielleadams
force-pushed
the
v15.12.0-proposal
branch
from
aba22e7 to
703aec8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Maybe it's still possible to pull that in #37712? 🙄 |
targos
approved these changes
Mar 17, 2021
PR-URL: #37712 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712 * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486
danielleadams
force-pushed
the
v15.12.0-proposal
branch
from
703aec8 to
5011009
Compare
This comment has been minimized.
This comment has been minimized.
danielleadams
added a commit
that referenced
this pull request
Mar 17, 2021
PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712 * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486
danielleadams
pushed a commit
to danielleadams/nodejs.org
that referenced
this pull request
Mar 17, 2021
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 17, 2021
targos
removed
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-03-17, Version 15.12.0 (Current), @danielleadams
Notable Changes
Commits
44514600b2] - assert,util: fix commutativity edge case (Ruben Bridgewater) #377118666d777cc] - benchmark: add benchmark for fsPromises.writeFile (Nitzan Uziely) #37610e9028eb646] - cluster: restructure to same prototype for cluster child (Yash Ladha) #366108e1257e26d] - cluster: clarify construct Handle (Jackson Tian) #37385341ee31e15] - crypto: reconcile duplicated code (James M Snell) #37704a2d08d5dfd] - crypto: add internal error codes (Darshan Sen) #37650922f2f0eb2] - (SEMVER-MINOR) crypto: add optional callback to crypto.sign and crypto.verify (Filip Skokan) #3750055e522ca23] - (SEMVER-MINOR) crypto: support JWK objects in create*Key (Filip Skokan) #3725433180fad81] - crypto: add separate error for INVALID_KEY_TYPE (Darshan Sen) #37555d81b9af1fc] - crypto: improve randomUUID performance (Dawid Rusnak) #3724323d654105f] - crypto,test: improve hmac coverage with webcrypto tests (obi-el) #37571dfca2fac24] - (SEMVER-MINOR) deps: update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712ce357c0c11] - (SEMVER-MINOR) deps: update archs files for OpenSSL-1.1.1+quic (James M Snell) #376016d77b6174f] - (SEMVER-MINOR) deps: switch openssl to quictls/openssl (James M Snell) #376013e1a46a6a8] - deps: upgrade npm to 7.6.3 (Ruy Adorno) #37721b2fd00398c] - deps: V8: cherry-pick 1648e050cade (Colin Ihrig) #376647422453072] - deps: upgrade npm to 7.6.1 (Ruy Adorno) #3760689f3aa92b4] - doc: add marsonya as a triager (marsonya) #376673710857de3] - doc: add hints to http.request() options (Luigi Pinca) #377455d793737d7] - (SEMVER-MINOR) doc: update maintaining-openssl guide (James M Snell) #376011022d3d947] - doc: recommend checking abortSignal.aborted first (James M Snell) #37714764aa2dcee] - doc: fix link to googletest fixtures (Tobias Nießen) #376980d3cc2dc82] - doc: fix typo in description of close event (Tobias Nießen) #37662e55058fed1] - doc: use sentence case in README.md headers (marsonya) #37645e7fc7a4c23] - doc: crypto esm examples (James M Snell) #37594a3abd52e1e] - doc: add localPort to http.request() options (Luigi Pinca) #37586705bdfbe3e] - doc: fix grammar errors in http document (Qingyu Deng) #37265e5f7179d1e] - doc: add document for http.OutgoingMessage (Qingyu Deng) #372657c0ce17e65] - doc: fix typo in doc/guides/collaborator-guide.md (marsonya) #3764360d8afa9ab] - doc: document that module.evaluate fulfills as undefined (James M Snell) #376636192315cf3] - doc: remove generated from dsaEncoding description (Marko Kaznovac) #37459e4c8c50b28] - doc: fix typos in /doc/api/fs.md (Merlin Luntke) #37557ebc6f41072] - doc: fix linter issue (Antoine du Hamel) #37657d17aab1775] - doc: add esm examples for assert (James M Snell) #37607366772bf87] - doc: add return type of readline.createInterface (Darshan Sen) #37600f50db89a52] - doc: change lang info string in fs JS snippets (Antoine du Hamel) #376055a9196e0e4] - doc: apply sentence case to headers in pull-requests.md (marsonya) #3760205badcf755] - doc: fix small typo in 15.11.0 release (Tierney Cyren) #37590e0e7aa1058] - doc: add top-level await syntax in vm.md (Antoine du Hamel) #37077732d8ca811] - doc: clarify that columnOffset applies only to the first line (James M Snell) #37563267bbe3412] - doc: document that NODE_EXTRA_CA_CERTS is read only once (James M Snell) #37562f56a805a0d] - doc: refactor signal info in child_process.md (Darshan Sen) #37528236ba04a79] - domain: add name to monkey-patched emit function (Colin Ihrig) #375501c09776106] - domain: show falsy names as anonymous for DEP0097 (Colin Ihrig) #375505a49e3139e] - errors: remove experimental from --enable-source-maps (Benjamin Coe) #37743e384291c90] - events: remove return value on addEventListener (James M Snell) #37696ba91ef2d08] - fs: improve fsPromises writeFile performance (Nitzan Uziely) #376103572299fc2] - fs: add promisified readFile benchmark (Nitzan Uziely) #37608b277776845] - fs: improve fsPromises readFile performance (Nitzan Uziely) #376086688569a50] - http: refactor to avoid unsafe array iteration (Antoine du Hamel) #37654c737df64fe] - http2: make res.req a normal property (Colin Ihrig) #37706ac2f50b3fd] - (SEMVER-MINOR) lib: implement AbortSignal.abort() (James M Snell) #3769312fb2ffc33] - lib: use AbortError consistently (James M Snell) #37715e63a25e2ff] - lib: fix typo in lib/internal/http2/core.js (marsonya) #37695852f53ed7e] - lib: fix typo in lib/internal/bootstrap/loaders.js (marsonya) #37644daa4ac54c5] - lib: remove use of array destructuring (Antoine du Hamel) #36818ae0e76c264] - module: refactor NativeModule to avoid unsafe array iteration (Antoine du Hamel) #37656a86334fbb9] - (SEMVER-MINOR) node-api: define version 8 (Gabriel Schulhof) #37652d28ce328ed] - src: fix variable name of OnCloseReceived callback (Tobias Nießen) #37521d59c6de7e8] - src: add error formatting support (Gus Caplan) #3759833436e39fe] - src: make BaseObject::is_snapshotable virtual (Anna Henningsen) #3753930c62dee1c] - src,test: support dynamically linking OpenSSL 3.0 (Daniel Bevenius) #376694bf1f333c7] - stream,util: fix "the the" typo in comments (Luigi Pinca) #376741b53087541] - (SEMVER-MINOR) test: update dom/abort tests (James M Snell) #37693c2cb153646] - (SEMVER-MINOR) test: fixup test to account for quic openssl version (James M Snell) #37601ede34aa128] - test: address flaky wpt/test-timers (Rich Trott) #37691ed32cd4e67] - test: fixup flaky test-crypto-x509 (Filip Skokan) #37709013b3ff2d4] - test: remove unnecessary V8 flag (Antoine du Hamel) #37671cc48816826] - test: fix WPT URL tests that fetch JSON data (Michaël Zasso) #37624b0ed1e790e] - test: improve error reporting in test-child-process-pipe-dataflow (Rich Trott) #37632f7edb07ec2] - test: terminate WPT workers after test completion (Michaël Zasso) #37627b7ef829dac] - test: ignore WPT worker errors after tests finished (Michaël Zasso) #37626257b1ab225] - test: update Web Platform Tests (Michaël Zasso) #376201f6341852f] - test: remove FLAKY status for test-async-hooks-http-parser-destroy (Rich Trott) #37636044fd2fc86] - test: remove FLAKY status for fixed test (Rich Trott) #37633d5ff50d2a7] - test: clear flaky designation for test-stream-pipeline-http2 (Rich Trott) #37631381fb98061] - test: clear FLAKY designation for test-http2-pipe (Rich Trott) #376310582c51754] - test: fix wasi/test-return-on-exit on 32-bit systems (Colin Ihrig) #376150d04b6c043] - test: fix flaky test-child-process-exec-abortcontroller-promisified (Antoine du Hamel) #37572a44daff34d] - test: update all Web Platform Tests (Michaël Zasso) #37467c09bd77daf] - test: redownload wpt fixtures with correct encoding (Michaël Zasso) #3746757319770bb] - test,crypto: ensure promises resolve in webcrypto tests (Antoine du Hamel) #376532d9b624668] - tls: refactor to avoid unsafe array iteration (Antoine du Hamel) #3765572af5d9895] - tools: parse changelogs only in the default branch (Antoine du Hamel) #37768bd62771a22] - tools: use bundled npm in update scripts (Ruy Adorno) #376134de3b8483a] - tools: update glob-parent to 5.1.2 (Rich Trott) #37646ec71a0f817] - tools: check version number in YAML comments from changelogs (Antoine du Hamel) #3759907fc61b900] - tools: add support for mjs and cjs JS snippet linting (Antoine du Hamel) #37311440c944420] - tools: fix object name in prefer-assert-methods.js (Tobias Nießen) #375447042ec89f1] - tools: update remark-preset-lint-node to 2.1.1 (Rich Trott) #3760482e78f7c12] - tools: fix compiler warning in inspector_protocol (Darshan Sen) #37573fd7234c52f] - tools: make update-eslint.sh work with npm@7 (Luigi Pinca) #37566057c6a842a] - tools: add ESLint rule no-array-destructuring (Antoine du Hamel) #3681825a5f0b3b8] - tools: update eslint-plugin-markdown configuration (Colin Ihrig) #375497a1de1fce9] - tools: update ESLint to 7.21.0 (Luigi Pinca) #375469c0ca4689d] - tools,doc: add support for several flavors of JS code snippets (Antoine du Hamel) #3716280af610d95] - util: inspect __proto__ key as written in object literal (Anna Henningsen) #377130d135e8316] - (SEMVER-MINOR) worker: add setEnvironmentData/getEnvironmentData (James M Snell) #374868024ffbba4] - worker: add ports property to MessageEvents (Anna Henningsen) #37538f4fd3fb6a7] - worker: allow BroadcastChannel in receiveMessageOnPort (Anna Henningsen) #37535