Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: remove experimental from --enable-source-maps #37743

Closed
wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 13, 2021

Missed updating the --help output when removing experimental language from docs.

@bcoe bcoe requested review from ruyadorno, iansu and Trott March 13, 2021 19:12
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 13, 2021
@bcoe
Copy link
Contributor Author

bcoe commented Mar 13, 2021

CC: @Flarna

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2021
@Trott
Copy link
Member

Trott commented Mar 14, 2021

Minor nit: Our guidelines say the first word after the subsystem in the commit message should be an imperative verb. So maybe this?:

errors: remove experimental from --enable-source-maps

@bcoe bcoe changed the title errors: --enable-source-maps remove experimental errors: remove experimental from --enable-source-maps Mar 15, 2021
@Flarna
Copy link
Member

Flarna commented Mar 15, 2021

Landed in ac73d58

@Flarna Flarna closed this Mar 15, 2021
Flarna pushed a commit that referenced this pull request Mar 15, 2021
PR-URL: #37743
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37743
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37743
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants