Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: ensure promises resolve in webcrypto tests #37653

Merged
merged 1 commit into from
Mar 13, 2021
Merged

test,crypto: ensure promises resolve in webcrypto tests #37653

merged 1 commit into from
Mar 13, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 8, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36562/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36669/

@aduh95
test,crypto: ensure promises resolve in webcrypto tests
dc8d54d 
PR-URL: nodejs#37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 13, 2021

Landed in dc8d54d

@aduh95 aduh95 closed this Mar 13, 2021
@aduh95 aduh95 merged commit dc8d54d into nodejs:master Mar 13, 2021
@aduh95 aduh95 deleted the webcrypt-assert-rejects branch March 13, 2021 09:38
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
test,crypto: ensure promises resolve in webcrypto tests
2577f10 
PR-URL: #37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
test,crypto: ensure promises resolve in webcrypto tests
5731977 
PR-URL: #37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @jasnell @Trott @targos