tools: check version number in YAML comments from changelogs #37599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
doc
nodejs-github-bot
added
the
meta
RaisinTen
approved these changes
Mar 4, 2021
RaisinTen
reviewed
Mar 4, 2021
tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs
Outdated
Show resolved
Hide resolved
aduh95
added
the
author ready
Trott
approved these changes
Mar 4, 2021
aduh95
force-pushed
the
lint-version-from-changelogs
branch
from
a5dbc78
to
a49d403
Compare
jasnell
approved these changes
Mar 5, 2021
|
fast-track? |
PR-URL: nodejs#37599 Refs: nodejs/remark-preset-lint-node#172 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
lint-version-from-changelogs
branch
from
a49d403
to
8de1e19
Compare
|
Landed in 8de1e19 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37599 Refs: nodejs/remark-preset-lint-node#172 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37599 Refs: nodejs/remark-preset-lint-node#172 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
marked dont-land-on LTS branches because we don't backport changelog updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/remark-preset-lint-node#172