[v14.x] deps: update ICU to 69.1

[targos]

• deps: V8: cherry-pick 035c305ce776
• deps: update ICU to 69.1

This is a clean cherry-pick of the 69.1 upgrade but it requires a V8 change to work.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37857/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3967/

[targos]

The linter issue is also present on v14.x-staging and comes from my last push. I don't understand why make lint-md doesn't catch it locally.

[targos]

I removed #37599 for the linter issue.

Now investigating the warnings that make test-linux fail.
Edit: I don't know... The lines are here since before v14.0.0 and I don't see what change would have fixed the warnings on master...

[richardlau]

FWIW I'm getting similar failures with --error-on-warn on master (c975dff) with gcc/g++ 10. I don't know why we're not seeing these on master in the GitHub actions workflow.

../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::Fill(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_buffer.cc:646:35: error: ‘start’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  646 |   char* ptr = ts_obj_data + start + str_length;
      |               ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::ASCII]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::BASE64]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::BASE64URL]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc:672:10: error: ‘max_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  672 |   size_t max_length;
      |          ^~~~~~~~~~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::BINARY]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc:672:10: error: ‘max_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  672 |   size_t max_length;
      |          ^~~~~~~~~~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::HEX]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::UCS2]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc:672:10: error: ‘max_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  672 |   size_t max_length;
      |          ^~~~~~~~~~
../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::StringWrite(const v8::FunctionCallbackInfo<v8::Value>&) [with node::encoding encoding = node::UTF8]’:
../src/node_buffer.cc:675:3: error: ‘offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  675 |   if (offset > ts_obj_length) {
      |   ^~
../src/node_buffer.cc:672:10: error: ‘max_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  672 |   size_t max_length;
      |          ^~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [libnode.target.mk:386: /var/home/rlau/sandbox/github/node/out/Release/obj.target/libnode/src/node_buffer.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm df07dd532335b97f9f86c77faf538e51e4326a8c.intermediate db010917bf4cd007e4a7e949a2f971606bec8c9a.intermediate bd9e0eec093d1a111d61ff3c9ed6a3abc0f019a2.intermediate
make: *** [Makefile:105: node] Error 2

real	7m21.887s
user	15m35.802s
sys	2m53.333s
⬢[rlau@toolbox node]$ git rev-parse HEAD
c975dff3c0f0f1ecb1574f3b10dd1d135a7704db
⬢[rlau@toolbox node]$ gcc --version
gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

⬢[rlau@toolbox node]$ g++ --version
g++ (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

⬢[rlau@toolbox node]$ 

[targos]

What can we do?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37869/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37876/

[targos]

Our CI is green. Can I have some reviews on this? I'll open a separate issue for the test-linux error.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38163/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4000/

[targos]

Landed in c260d98...55d0cd8