Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add return type of readline.createInterface #37600

Merged
merged 1 commit into from
Mar 6, 2021
Merged

doc: add return type of readline.createInterface #37600

merged 1 commit into from
Mar 6, 2021

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Mar 4, 2021
@benjamingr
Copy link
Member

Good catch

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

fast-track?

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 6, 2021
@RaisinTen @aduh95
doc: add return type of readline.createInterface
d63b717 
PR-URL: nodejs#37600
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the doc/add-return-type-of-readline.createInterface branch from 4b1e3f4 to d63b717 Compare March 6, 2021 17:54
@aduh95
Copy link
Contributor

aduh95 commented Mar 6, 2021

Landed in d63b717

@aduh95 aduh95 merged commit d63b717 into nodejs:master Mar 6, 2021
@RaisinTen RaisinTen deleted the doc/add-return-type-of-readline.createInterface branch March 7, 2021 11:56
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@RaisinTen @danielleadams
doc: add return type of readline.createInterface
366772b 
PR-URL: #37600
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
doc: add return type of readline.createInterface
b192227 
PR-URL: #37600
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RaisinTen @benjamingr @jasnell @aduh95 @Trott @lpinca @marsonya @nodejs-github-bot