Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: allow BroadcastChannel in receiveMessageOnPort #37535

Closed
wants to merge 2 commits into from
Closed

worker: allow BroadcastChannel in receiveMessageOnPort #37535

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Feb 27, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36401/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36406/

addaleax added a commit that referenced this pull request Mar 3, 2021
@addaleax
worker: allow BroadcastChannel in receiveMessageOnPort
9dd2f9f 
PR-URL: #37535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax
Copy link
Member Author

addaleax commented Mar 3, 2021

Landed in 9dd2f9f

@addaleax addaleax closed this Mar 3, 2021
@addaleax addaleax deleted the receive-message-bc branch March 3, 2021 22:23
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@addaleax @danielleadams
worker: allow BroadcastChannel in receiveMessageOnPort
f4fd3fb 
PR-URL: #37535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @targos @cjihrig