Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change lang info string in fs JS snippets #37605

Merged
merged 1 commit into from
Mar 6, 2021
Merged

doc: change lang info string in fs JS snippets #37605

merged 1 commit into from
Mar 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 4, 2021 •
edited
Loading

@aduh95 aduh95 added doc Issues and PRs related to the documentations. blocked PRs that are blocked by other issues or PRs. labels Mar 4, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 4, 2021
@aduh95 aduh95 mentioned this pull request Mar 4, 2021
Merged
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Mar 4, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed tools Issues and PRs related to the tools directory. labels Mar 4, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

fast-track?

@aduh95 aduh95 self-assigned this Mar 5, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 6, 2021

Anyone wants to 👍 the fast track request so I can land #37311?

@aduh95 @Trott
doc: change lang info string in fs JS snippets
0946164 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott
Copy link
Member

Trott commented Mar 6, 2021

Landed in 0946164

@Trott Trott merged commit 0946164 into nodejs:master Mar 6, 2021
@aduh95 aduh95 deleted the fs-lang-fenced branch March 6, 2021 15:03
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
doc: change lang info string in fs JS snippets
f50db89 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit to targos/node that referenced this pull request Aug 8, 2021
@aduh95 @targos
doc: change lang info string in fs JS snippets
e5744a3 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Aug 8, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Aug 13, 2021
@aduh95 @targos
doc: change lang info string in fs JS snippets
fd0d821 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Sep 1, 2021
@aduh95 @targos
doc: change lang info string in fs JS snippets
e912108 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Sep 1, 2021
@aduh95 @targos
doc: change lang info string in fs JS snippets
f5b2fe1 
Refs: nodejs/remark-preset-lint-node#176

PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@danielleadams danielleadams danielleadams approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@aduh95 aduh95

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @jasnell @Trott @benjamingr @danielleadams @marsonya @RaisinTen @targos @nodejs-github-bot