-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add support for meta info in JS snippet linting #37311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
tools
Issues and PRs related to the tools directory.
labels
Feb 10, 2021
aduh95
commented
Feb 10, 2021
aduh95
added a commit
to aduh95/remark-preset-lint-node
that referenced
this pull request
Feb 23, 2021
aduh95
added a commit
to aduh95/remark-preset-lint-node
that referenced
this pull request
Feb 23, 2021
This needs a rebase. |
Trott
pushed a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Mar 4, 2021
aduh95
force-pushed
the
better-lint-js-in-md
branch
from
March 4, 2021 20:46
3cc74f8
to
93c4095
Compare
I think fs.md needs to be updated (based on the linting results)? |
Good catch. That's done in #37605. |
aduh95
force-pushed
the
better-lint-js-in-md
branch
from
March 4, 2021 21:54
93c4095
to
a95ef66
Compare
Trott
approved these changes
Mar 4, 2021
Refs: nodejs#37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
force-pushed
the
better-lint-js-in-md
branch
from
March 6, 2021 15:06
0d2b5aa
to
0afc8ac
Compare
Landed in 0afc8ac |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <rtrott@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #37162
Refs: eslint/markdown#172
//cc @nodejs/linting