Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix typo in lib/internal/bootstrap/loaders.js #37644

Closed
wants to merge 1 commit into from
Closed

lib: fix typo in lib/internal/bootstrap/loaders.js #37644

wants to merge 1 commit into from

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Mar 6, 2021

'bootstrapped' spelled as 'bootstraped'

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 6, 2021
@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@benjamingr benjamingr removed the needs-ci PRs that need a full CI run. label Mar 10, 2021
@benjamingr
Copy link
Member

benjamingr commented Mar 10, 2021 •
edited
Loading

This should not need (jenkins) ci as a docs only change. (github ci passed)

@benjamingr
Copy link
Member

Landed in 4b5db00 🎉 thanks!

benjamingr pushed a commit that referenced this pull request Mar 10, 2021
@marsonya @benjamingr
lib: fix typo in lib/internal/bootstrap/loaders.js
4b5db00 
PR-URL: #37644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@benjamingr benjamingr closed this Mar 10, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @danielleadams
lib: fix typo in lib/internal/bootstrap/loaders.js
852f53e 
PR-URL: #37644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
lib: fix typo in lib/internal/bootstrap/loaders.js
eea4f3b 
PR-URL: #37644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marsonya @benjamingr @Trott @addaleax @RaisinTen @PoojaDurgad @nodejs-github-bot