Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: fix session and keylog add listener segfault #38180

Closed
wants to merge 3 commits into from
Closed

tls: fix session and keylog add listener segfault #38180

wants to merge 3 commits into from

Conversation

Linkgoron
Copy link
Member

@Linkgoron Linkgoron commented Apr 9, 2021 •
edited
Loading

Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed causes a segfault.

fixes: #38133
fixes: #38135

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Apr 9, 2021
@Linkgoron Linkgoron force-pushed the tls-fix-call-after-destroy branch 3 times, most recently from 80f37a5 to 68d7662 Compare April 9, 2021 23:18
@Linkgoron
tls: fix session and keylog add listener segfault
581c0be 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: nodejs#38133
fixes: nodejs#38135
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37351/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37352/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37359/

@Linkgoron Linkgoron added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2021
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

Landed in 3da003c

@jasnell jasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@Linkgoron @jasnell
tls: fix session and keylog add listener segfault
3da003c 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: #38133
fixes: #38135

PR-URL: #38180
Fixes: #38133
Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Linkgoron @BethGriggs
tls: fix session and keylog add listener segfault
868da60 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: #38133
fixes: #38135

PR-URL: #38180
Fixes: #38133
Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@Linkgoron @targos
tls: fix session and keylog add listener segfault
4ba0659 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: #38133
fixes: #38135

PR-URL: #38180
Fixes: #38133
Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@Linkgoron @targos
tls: fix session and keylog add listener segfault
607aa9a 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: #38133
fixes: #38135

PR-URL: #38180
Fixes: #38133
Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@Linkgoron @targos
tls: fix session and keylog add listener segfault
661e980 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: #38133
fixes: #38135

PR-URL: #38180
Fixes: #38133
Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
5 participants
@Linkgoron @nodejs-github-bot @jasnell @lpinca @zyscoder