doc: clarify DiffieHellmanGroup class docs #38363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation.
nodejs-github-bot
added
crypto
bengl
reviewed
Apr 23, 2021
bengl
reviewed
Apr 23, 2021
Trott
reviewed
Apr 27, 2021
Trott
reviewed
Apr 27, 2021
Linkgoron
force-pushed
the
docs-crypto-clarify-dhg
branch
from
cb595b7
to
5473d41
Compare
jasnell
approved these changes
Apr 29, 2021
edsadr
approved these changes
May 1, 2021
jasnell
approved these changes
May 4, 2021
|
Landed in 9643128 |
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation (it's already mentioned in the docs - but only in the documentation for the
getDiffieHellmanmethod).