v16.2.0 release proposal #38719
Merged
v16.2.0 release proposal #38719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit skips some test when OpenSSL 3.0.0-alpha15 is used as there is an issue that causes them to fail. This is only a temp solution until there is new OpenSSL release. Fixes: #38373 PR-URL: #38451 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Original commit message:
```
PPC: Add Power10 to the supported list and enable related features
This CL adds Power10 recognition to Linux, AIX as well as IBMi.
Enabled features include:
MODULO
FPR_GPR_MOV
SIMD
LWSYNC
ISELECT
VSX
Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Junliang Yan <junyan@redhat.com>
Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#74279}
```
Refs: v8/v8@530080c
PR-URL: #38489
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #38431 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Use sentence case consistently in headers in src/crypto/README.md. PR-URL: #38524 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #38500 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
When rendered by `man node`, all flags have a dash prepended to them. Prior to this change, the man page would incorrectly read `---unhandled-rejections=mode` The three dashes is invalid syntax and rejected by the `node` command. PR-URL: #38532 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The name ‘gnu++1y’ is deprecated. Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html PR-URL: #38504 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #38516 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
PR-URL: #38502 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Both for consistency within the doc and to conform with IBM's usage regarding their on product, refer to the operating system as AIX rather than Aix. PR-URL: #38535 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
The content we're linking to for AHAFS was published in 2011 but has now been archived. This updates the link to the archived version (as the current version results in a "Yikes!" page with an HTTP 400 response code). Unfortunately, the archived version does say "This content is no longer being updated or maintained. The content is provided “as is.” Given the rapid evolution of technology, some content, steps, or illustrations may have changed." So we'll want to update at some point I imagine. But for the moment, archived content with a notice like that is better than a broken link. PR-URL: #38534 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Added JSDoc typings for the `readline` lib module. PR-URL: #38253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/blob.js.html#L132 PR-URL: #38515 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/abort_controller.js.html#L126 PR-URL: #38514 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #38520 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/querystring.js.html#L179 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #38518 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Fixes: #38540 PR-URL: #38542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #38523 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38530 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
In the user perspective, it's not an arguemnt type error. Replace it with an `assert` expression. PR-URL: #38519 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/fs/promises.js.html#L268 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38517 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/fs.js.html#L330 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
@nodejs/releasers |
nit: undesirable underscore escaping |
targos
added a commit
that referenced
this pull request
May 18, 2021
Notable changes: async_hooks: * (SEMVER-MINOR) use new v8::Context PromiseHook API (Stephen Belanger) #36394 lib: * support setting process.env.TZ on windows (James M Snell) #38642 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 process: * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 util: * (SEMVER-MINOR) add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619 PR-URL: #38719
|
Thanks! I updated changelog-maker and regenerated the commit list. |
|
Release build: https://ci-release.nodejs.org/job/iojs+release/6894/ |
richardlau
approved these changes
May 18, 2021
danielleadams
approved these changes
May 18, 2021
|
|
|
It's a known issue (#38226) with two open PRs: |
|
Okay, thanks. Given that and the current issues with GitHub actions, I think I'll wait until tomorrow to do the release. |
Notable changes: async_hooks: * (SEMVER-MINOR) use new v8::Context PromiseHook API (Stephen Belanger) #36394 lib: * support setting process.env.TZ on windows (James M Snell) #38642 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 process: * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 util: * (SEMVER-MINOR) add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619 PR-URL: #38719
|
If that's a known issue, can I ignore the CI failure and proceed with the release? It doesn't seem to be useful to chain reruns until it passes by chance. |
BethGriggs
approved these changes
May 19, 2021
targos
added a commit
that referenced
this pull request
May 19, 2021
Notable changes: async_hooks: * (SEMVER-MINOR) use new v8::Context PromiseHook API (Stephen Belanger) #36394 lib: * support setting process.env.TZ on windows (James M Snell) #38642 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 process: * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 util: * (SEMVER-MINOR) add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619 PR-URL: #38719
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
May 19, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-05-19, Version 16.2.0 (Current), @targos
Notable Changes
36b948560c] - (SEMVER-MINOR) async_hooks: use new v8::Context PromiseHook API (Stephen Belanger) #36394c0deeeacb2] - lib: support setting process.env.TZ on windows (James M Snell) #386424c4902748c] - (SEMVER-MINOR) module: add support forURLtoimport.meta.resolve(Antoine du Hamel) #38587c182198c44] - (SEMVER-MINOR) process: add'worker'event (James M Snell) #38659fbf02e3198] - (SEMVER-MINOR) util: add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619Commits
36b948560c] - (SEMVER-MINOR) async_hooks: use new v8::Context PromiseHook API (Stephen Belanger) #36394dcae03203e] - buffer: remove TODOs inatob/btoa(Khaidi Chu) #3854848b557e904] - buffer: remove unreachable code (Rongjian Zhang) #38537b0df28dea5] - build: add workaround for V8 builds (Richard Lau) #386323bb12db255] - build: remove dependency ondistutils.spawn(Richard Lau) #3860010aaf30da1] - build: add missing torque output sources (Richard Lau) #3857603b4a3a5bf] - build: compile with -std=gnu++14 (Darshan Sen) #385044296591154] - build,src,test,doc: enable FIPS for OpenSSL 3.0 (Daniel Bevenius) #3863336bb8daba5] - crypto: forbid NODE-ED25519 and NODE-ED448 "raw" key export (Filip Skokan) #3866836bb7243ff] - debugger: refactorinspect\_replto use primordials (Antoine du Hamel) #3855116a6c8d5a6] - debugger: refactor to use internal modules (Antoine du Hamel) #3855011dd9a6838] - debugger: disable only the lint rules required by current file state (Rich Trott) #38529e79f540fa0] - debugger: avoid non-ASCII char in code file (Rich Trott) #38529d9867b9358] - debugger: wrap lines longer than 80 chars (Rich Trott) #38529352a600142] - debugger: rename inspector-cli test module to debugger (Rich Trott) #38530608d0e11f3] - deps: upgrade npm to 7.13.0 (Ruy Adorno) #386825c71f49d3f] - deps: upgrade npm to 7.12.1 (Ruy Adorno) #38628ec2dbfb200] - deps: patch V8 to 9.0.257.25 (Michaël Zasso) #38556ab298723b5] - (SEMVER-MINOR) deps: V8: cherry-pick fa4cb172cde2 (Stephen Belanger) #36394a84e9b3e7d] - (SEMVER-MINOR) deps: V8: cherry-pick 4c074516397b (Stephen Belanger) #36394043b1aaa3f] - (SEMVER-MINOR) deps: V8: cherry-pick 5f4413194480 (Stephen Belanger) #363941a104bac74] - (SEMVER-MINOR) deps: V8: cherry-pick 272445f10927 (Stephen Belanger) #36394827ae05538] - (SEMVER-MINOR) deps: V8: backport c0fceaa0669b (Stephen Belanger) #36394f31a6114a4] - deps: V8: cherry-pick 530080c44af2 (Milad Fa) #384894001dd28ba] - dgram: extract cluster lazy loading method to make it testable (Rongjian Zhang) #38563a0dc194e31] - doc: document buffer.kStringMaxLength (Tobias Nießen) #386888590c151cd] - doc: update abort signal in fs promise api example (Moritz Kneilmann) #386690100a3b026] - doc: add documentation for fs.WriteStream.close() (Hitesh Sharma) #386105c38a554ec] - doc: clarify synchronous blocking of Worker stdio (James M Snell) #386581765e32c45] - doc: update contact info (Gabriel Schulhof) #38689c4b161cb89] - doc: change color of doctag on night mode (Qingyu Deng) #386526620a3182e] - doc: add ESM code examples in url.md (Antoine du Hamel) #38651d3de0ef5d4] - doc: fix fs.openSync() signature (Luigi Pinca) #3859156bf6c1bcd] - doc: typo stats() should be stat(); clarity (Bryan Field) #385411d9fd49f41] - doc: fix code example in ecdh.setPublicKey() (Jordan Baczuk) #385424c70e42928] - doc: useHEADinstead ofmasterfor links (Antoine du Hamel) #38518ae9128ec61] - doc: clarify DiffieHellmanGroup class docs (Nitzan Uziely) #38363e59131d97f] - doc: fix broken AHAFS link in fs doc (Rich Trott) #38534e9d4c8587a] - doc: use AIX instead of Aix in fs.md (Rich Trott) #38535e0118f347a] - doc: remove extraneous dash from flag prefix (Rodolfo Carvalho) #385329e10e1a76f] - doc: corrected workload name as per the latest VS Installer (MrJithil) #3850038644d6f96] - doc: use sentence case in headers in src/crypto/README.md (Rich Trott) #38524347b9f2304] - errors: remove input from ERR_INVALID_URL message (moander) #386145b40e2f596] - events: use nullish coalencing operator (Voltrex) #383283a5856cbc3] - fs: fix async iterator partial writes (Nitzan Uziely) #38615e8761186a5] - fs: fix error when writing buffers > INT32_MAX (Zach Bjornson) #3854647080bcfc8] - fs: useassertinfsCallargument checking (Rongjian Zhang) #385193d8b8e133f] - http: refactor to remove redundant argument of _deferToConnect (Rongjian Zhang) #38598c0deeeacb2] - lib: support setting process.env.TZ on windows (James M Snell) #38642cf4dc80d5f] - lib: makeIterableWeakMapsafe to iterate (Antoine du Hamel) #3852390b640efb1] - meta: add v8 team (Jiawen Geng) #385664c4902748c] - (SEMVER-MINOR) module: add support forURLtoimport.meta.resolve(Antoine du Hamel) #3858714a2a00cda] - node-api: faster threadsafe_function (Fedor Indutny) #38506be4b3a4164] - path: inline conditions (Voltrex) #38613c182198c44] - (SEMVER-MINOR) process: add'worker'event (James M Snell) #38659e2b8454582] - repl: fix Ctrl+C on top level await (Antoine du Hamel) #38656718ad105e5] - src: fix fatal errors when a current isolate not exist (legendecas) #38624524a9d6fcd] - src: update cares_wrap OpenBSD defines (Anna Henningsen) #386706b409cf664] - src: remove extra semi after member fn (Shelley Vohr) #38686bfec80fd66] - src: make workers messaging more resilient (Juan José Arboleda) #38510ff1b4322f5] - test: refactortest-readline-interfaceto be shorter (Juan José Arboleda) #386918eea317227] - test: stream.finished detects a destroyed IncomingMessage (Nitzan Uziely) #386615b25fbe266] - test: set common.bits to 64 for riscv64 (Andreas Schwab) #386265a0b52120a] - test: improve coverage of lib/_http_client.js (Rongjian Zhang) #385993d0fad3840] - test: improve coverage of lib/os.js (Rongjian Zhang) #3865316b2fb4e0c] - test: increase coverage for repl (ZiJian Liu) #385598f78c6646e] - test: call functions internally (Voltrex) #38560178fe215a4] - test: increase coverage for Histogram (ZiJian Liu) #3855595db7d5afc] - test: improve fs coverage (Rongjian Zhang) #38517f2f768f261] - test: complete coverage of querystring (Rongjian Zhang) #385205b44107ae9] - test: increase coverage for AbortController (ZiJian Liu) #38514662265074c] - test: increase coverage for Blob (ZiJian Liu) #3851589e1daccf3] - test: run message and pseudo-tty tests in parallel (Richard Lau) #38502727c2bcc24] - test: move test-net-connect-econnrefused from pummel to sequential (Rich Trott) #38462e64ebac2da] - test: fix flaky inspector-cli tests when breakpionts are restored (Rich Trott) #38431b51b4feece] - test: skip tests for openssl-3.0.0-alpha15 (Daniel Bevenius) #38451db5ee23edf] - test: update OpenSSL 3.0.0-alpha15 error messages (Daniel Bevenius) #3845124472d9e0c] - test,repl: fix tests when inspector is disabled (Antoine du Hamel) #38564267a84f5e1] - tools: remove redundant v8 config (Jiawen Geng) #38565a028805f1b] - tools: update ESLint to 7.26.0 (Colin Ihrig) #38605ec8ab22ce6] - (SEMVER-MINOR) tools: addWorkerto type-parser (James M Snell) #38659151488539b] - tools: make GH Actions workflows work if default branch is not master (Antoine du Hamel) #38516c0f0c9a92d] - typings: add JSDoc typings for readline (Voltrex) #38253fbf02e3198] - (SEMVER-MINOR) util: add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619070ee4bb94] - Revert "worker: removeERR\_CLOSED\_MESSAGE\_PORT" (Juan José Arboleda) #38510