Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence case in headers in src/crypto/README.md #38524

Merged
merged 1 commit into from
May 4, 2021
Merged

doc: use sentence case in headers in src/crypto/README.md #38524

merged 1 commit into from
May 4, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented May 3, 2021

Use sentence case consistently in headers in src/crypto/README.md.

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 3, 2021
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added doc Issues and PRs related to the documentations. and removed c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 4, 2021
@Trott
doc: use sentence case in headers in src/crypto/README.md
f71166b 
Use sentence case consistently in headers in src/crypto/README.md.

PR-URL: nodejs#38524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member Author

Trott commented May 4, 2021

Landed in f71166b

@Trott Trott merged commit f71166b into nodejs:master May 4, 2021
@Trott Trott deleted the crypto-readme branch May 4, 2021 13:34
targos pushed a commit that referenced this pull request May 17, 2021
@Trott @targos
doc: use sentence case in headers in src/crypto/README.md
38644d6 
Use sentence case consistently in headers in src/crypto/README.md.

PR-URL: #38524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @cjihrig @gireeshpunathil @Lxxyx @aduh95 @panva @targos