Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add missing torque output sources #38576

Merged
merged 1 commit into from
May 7, 2021
Merged

build: add missing torque output sources #38576

merged 1 commit into from
May 7, 2021

Conversation

richardlau
Copy link
Member

The torque_generated_definitions target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

Fixes: #38571

Syncs our gyp file with

node/deps/v8/BUILD.gn

Lines 1618 to 1625 in e46c680

foreach(file, torque_files) {
filetq = string_replace(file, ".tq", "-tq")
sources += [
"$target_gen_dir/torque-generated/$filetq-inl.inc",
"$target_gen_dir/torque-generated/$filetq.cc",
"$target_gen_dir/torque-generated/$filetq.inc",
]
}

cc @john-yan @nodejs/v8-update

@github-actions github-actions bot added the needs-ci PRs that need a full CI run. label May 6, 2021
@richardlau richardlau mentioned this pull request May 6, 2021
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau richardlau added the build Issues and PRs related to build files or the CI. label May 6, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37953/ 💚

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2021
@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels May 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@richardlau
build: add missing torque output sources
184e0f7 
The `torque_generated_definitions` target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

PR-URL: nodejs#38576
Fixes: nodejs#38571
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau
Copy link
Member Author

Landed in 184e0f7.

@richardlau richardlau merged commit 184e0f7 into nodejs:master May 7, 2021
@richardlau richardlau deleted the non-optimized-debug branch May 7, 2021 18:11
@richardlau richardlau mentioned this pull request May 11, 2021
Merged
targos pushed a commit that referenced this pull request May 17, 2021
@richardlau @targos
build: add missing torque output sources
10aaf30 
The `torque_generated_definitions` target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

PR-URL: #38576
Fixes: #38571
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js would not compile with --debug --v8-non-optimized-debug
7 participants
@richardlau @nodejs-github-bot @jasnell @addaleax @targos @cjihrig @gengjiawen