Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve fs coverage #38517

Closed
wants to merge 1 commit into from
Closed

test: improve fs coverage #38517

wants to merge 1 commit into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 3, 2021 •
edited
Loading

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 3, 2021
@aduh95 aduh95 mentioned this pull request May 3, 2021
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2021
@richardlau

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37950/ 💚

jasnell pushed a commit that referenced this pull request May 6, 2021
@pd4d10 @jasnell
test: improve fs coverage
2465062 
PR-URL: #38517
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/fs.js.html#L330
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 6, 2021

Landed in 2465062

@jasnell jasnell closed this May 6, 2021
@pd4d10 pd4d10 deleted the patch-1 branch May 6, 2021 17:59
targos pushed a commit that referenced this pull request May 17, 2021
@pd4d10 @targos
test: improve fs coverage
95db7d5 
PR-URL: #38517
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/fs.js.html#L330
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
@LiviaMedeiros LiviaMedeiros mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pd4d10 @nodejs-github-bot @richardlau @jasnell @Trott @RaisinTen @targos