build: compile with -std=gnu++14 #38504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name ‘gnu++1y’ is deprecated. Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html
github-actions
bot
added
build
|
@RaisinTen Do you know the gcc version which introduced the gnu++14 spelling? |
|
@addaleax I think it was introduced in |
|
Cool, then I’d say we don’t land this on LTS branches because some people probably still find their way of building with gcc 4.9, but this should be fine 👍 |
addaleax
approved these changes
May 3, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
jasnell
approved these changes
May 3, 2021
richardlau
approved these changes
May 3, 2021
Trott
approved these changes
May 3, 2021
jasnell
added
fast-track
|
Landed in f9d6de4 |
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
The name ‘gnu++1y’ is deprecated. Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html PR-URL: #38504 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
The name ‘gnu++1y’ is deprecated. Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html PR-URL: #38504 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name ‘gnu++1y’ is deprecated.
Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html