Revert "stream: error Duplex write/read if not writable/readable"

[targos]

This reverts commit 954217a.

It breaks npm.

[targos]

To reproduce the issue before this commit:

rm -rf tools/doc/node_modules
make doc

[targos]

Here's the related code in npm that doesn't work as expected with the change:

https://github.com/npm/gauge/blob/e1839fb2fddb15b6e468ff5ec90086c3c59e084d/index.js#L226-L232

It seems that either the write method now returns false instead of true, or the 'drain' event is no longer emitted.
_writeTo is the process.stderr stream.

[ronag]

I’ll take a look tonight

[ronag]

@targos any possibility of a repro using just gauge?

[targos]

@ronag

var Gauge = require('./deps/npm/node_modules/gauge/index.js');

var gauge = new Gauge(process.stderr, {
  theme: {hasColor: true},
  template: [
    {type: 'progressbar', length: 20},
    {type: 'activityIndicator', kerning: 1, length: 1},
    {type: 'section', default: ''},
    ':',
    {type: 'logline', kerning: 1, default: ''}
  ]
})

gauge.show("working…", 0)
setTimeout(() => { gauge.pulse(); gauge.show("working…", 0.25) }, 500)
setTimeout(() => { gauge.pulse(); gauge.show("working…", 0.50) }, 1000)
setTimeout(() => { gauge.pulse(); gauge.show("working…", 0.75) }, 1500)
setTimeout(() => { gauge.pulse(); gauge.show("working…", 0.99) }, 2000)
setTimeout(() => gauge.hide(), 2300)

[ronag]

There is a redraw live loop bug in gauge… I’m not sure what change triggers it. It unnecessarily calls redraw in drain. I’ll try and see if I can workaround it without changing gauge.

[ronag]

Fixed in #39253