Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: enable buffering #39253

Closed
wants to merge 5 commits into from
Closed

tty: enable buffering #39253

wants to merge 5 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 3, 2021 •
edited
Loading

HWM was set to 0 which would cause e.g. stdout.write(...) to
always return false.

Partly reverts 954217a

Refs: #39246

@ronag
tty: enable buffering
1dd2f48 
HWM was set to 0 which would cause e.g. stdout.write(...) to
always return false.

Refs: nodejs#39246
@ronag ronag requested a review from targos July 3, 2021 20:11
@github-actions github-actions bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 3, 2021
@ronag
Copy link
Member Author

ronag commented Jul 3, 2021

@targos not sure who's a good ping on this module?

@ronag
Copy link
Member Author

ronag commented Jul 3, 2021

@nodejs/streams

@wa-Nadoo
Copy link

wa-Nadoo commented Jul 3, 2021

I think the highWaterMark removal from is_main_thread.js (954217a#diff-c09055446adf1d69b81595307e964da2121690a1d1bf2121845c9fcac0d86c86L152) should be reverted too. It was added years ago (bb56dcc#diff-36b7877cd8c72d2e5aa27243c142181d67d7be164927bae7503af6a720203aaeR500), and its removal can be pretty breaking.

@ronag ronag added review wanted PRs that need reviews. stream Issues and PRs related to the stream subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38847/

@addaleax addaleax added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v12.x labels Jul 4, 2021
@ronag
Copy link
Member Author

ronag commented Jul 5, 2021

@addaleax this is a partial revert. Isn't it better without the semver major label and instead don't land labels or what's the thought?

addaleax
addaleax reviewed Jul 5, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronag Yeah, I don’t see any issues with setting the HWM for the writable side here.

lib/tty.js Show resolved Hide resolved
@ronag ronag requested review from addaleax and jasnell July 5, 2021 19:55
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38866/

addaleax
addaleax approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

benjamingr
benjamingr approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v12.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jul 6, 2021
ronag added a commit that referenced this pull request Jul 7, 2021
@ronag
tty: enable buffering
a8a8638 
HWM was set to 0 which would cause e.g. stdout.write(...) to
always return false.

Refs: #39246

PR-URL: #39253
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag
Copy link
Member Author

ronag commented Jul 7, 2021

Landed in a8a8638

@ronag ronag closed this Jul 7, 2021
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos Awaiting requested review from targos

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @wa-Nadoo @nodejs-github-bot @addaleax @benjamingr