v16.4.2 proposal #39270
Merged
v16.4.2 proposal #39270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well known user account names are localized on Windows. Look up the "Authenticated Users" user by its security identifier to get the localized name. PR-URL: #39241 Fixes: #39224 Refs: e817ba7 Refs: https://hackerone.com/reports/1211160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Notable changes: Node.js 16.4.1 introduced a regression in the Windows installer on non-English locales that is being fixed in this release. There is no need to download this release if you are not using the Windows installer. PR-URL: #39270
github-actions
bot
added
lib / src
BethGriggs
force-pushed
the
v16.4.2-proposal
branch
from
40ec72a
to
8d1d311
Compare
richardlau
approved these changes
Jul 5, 2021
|
Release build on 8d1d311: https://ci-release.nodejs.org/job/iojs+release/7012/ (private) |
targos
approved these changes
Jul 5, 2021
BethGriggs
added a commit
that referenced
this pull request
Jul 5, 2021
Notable changes: Node.js 16.4.1 introduced a regression in the Windows installer on non-English locales that is being fixed in this release. There is no need to download this release if you are not using the Windows installer. PR-URL: #39270
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Jul 5, 2021
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 5, 2021
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-07-05, Version 16.4.2 (Current), @BethGriggs
Notable Changes
Node.js 16.4.1 introduced a regression in the Windows installer on
non-English locales that is being fixed in this release. There is no
need to download this release if you are not using the Windows
installer.
Commits
76e709ec63] - win,msi: use localized "Authenticated Users" name (Richard Lau) #39241