Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(async-hooks): correct cjs code to match mjs code #39509

Closed
wants to merge 1 commit into from
Closed

doc(async-hooks): correct cjs code to match mjs code #39509

wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jul 24, 2021
@rluvaton rluvaton changed the title docs(async-hooks): correct cjs code to match mjs code doc(async-hooks): correct cjs code to match mjs code Jul 24, 2021
@rluvaton
Copy link
Member Author

rluvaton commented Jul 28, 2021 •
edited
Loading

How many reviewers need to approve before a PR can be merged? 😀

@lpinca
Copy link
Member

lpinca commented Aug 16, 2021

Landed in e087d78.

lpinca pushed a commit that referenced this pull request Aug 16, 2021
@rluvaton @lpinca
doc: correct cjs code to match mjs code
e087d78 
PR-URL: #39509
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@lpinca lpinca closed this Aug 16, 2021
@rluvaton rluvaton deleted the patch-1 branch August 16, 2021 14:06
@rluvaton
Copy link
Member Author

Thank you @lpinca
Is there a reason why this PR flagged as closed rather then merged?

@lpinca
Copy link
Member

lpinca commented Aug 16, 2021 •
edited
Loading

That's how PRs are merged in Node.js core. See https://github.com/nodejs/node/blob/966060df0e4aa7d79bfdd9fe2163b12298cf59b7/doc/guides/collaborator-guide.md#landing-pull-requests.

danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@rluvaton @danielleadams
doc: correct cjs code to match mjs code
5d66646 
PR-URL: #39509
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rluvaton @lpinca @jasnell @tniessen @vdeturckheim @HarshithaKP @targos @nodejs-github-bot