v16.7.0 release proposal #39782
Merged
v16.7.0 release proposal #39782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All API introduced in this PR are compliant with web [performance-timeline](https://w3c.github.io/performance-timeline) spec. "performance-timeline" is listed as supported web spec in the doc https://nodejs.org/docs/latest/api/perf_hooks.html#perf_hooks_performance_measurement_apis. Changes summary: 1. Add new supported wpt test subsets: user-timing and performance-timeline. 2. Add support for `Performance.getEntries`, `Performance.getEntriesByName` and `Performance.getEntriesByType` to synchronously fetch buffered performance entries. This means the user should invoke `Performance.clearMarks` and `Performance.clearMeasures` to clear buffered entries to prevent from those entries been kept alive forever. 3. Add support (again after #37136) for `buffered` flags for `PerformanceObserver`. 3. Fixes `PerformanceMark` and `PerformanceMeasure` wpt compliance issues. 4. Only user-created performance entries will be buffered globally. This behavior should be compliant with https://w3c.github.io/timing-entrytypes-registry/#registry. With the new ability to fetch user-created performance entries synchronously, the issues raised in nodejs/diagnostics#464 (comment) could also be fixed. PR-URL: #39297 Reviewed-By: James M Snell <jasnell@gmail.com>
The option buffered is not about queueing the PerformanceEntrys with an event loop task or not. The option buffered in the spec is about filling the observer with the global PerformanceEntry buffer. The current (and the spec) behavior is different with Node.js version <= v16.0.0. PR-URL: #39514 Refs: https://w3c.github.io/performance-timeline/#observe-method Refs: https://nodejs.org/dist/latest-v14.x/docs/api/perf_hooks.html#perf_hooks_performanceobserver_observe_options Refs: #39297 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
George does not appear to be active in Node.js for quite some time (correction welcome!) and my attempts to get in touch have failed. PR-URL: #39539 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: George Adams <george.adams@microsoft.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Update ESLint to 7.31.0 PR-URL: #39424 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Update email for Zeyu Yang. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update email for Shelley Vohr to correspond to what is specified in .mailmap and what is used in more recently authored commits. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update email for Ujjwal Sharma. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39455 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39454 Reviewed-By: James M Snell <jasnell@gmail.com>
This change properly decodes the url.username and url.password for the authorization header constructed from the URL object for http(s) requests. Fixes: #31439 PR-URL: #39310 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #39459 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the `lts/*` shorthand for "most recent LTS version". PR-URL: #39538 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39559 Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff` commands as these indicate pull requests that are being manually backported and should not be cherry-picked. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Put the command examples for finding and replacing the `REPLACEME` tags into code fences so that they are more easily copiable when viewing the guide in the GitHub web UI. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
We no longer produced ARMv6 builds, and the ARMv7 builds are now cross compiled and are as quick as builds on the other platforms. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Move the section on `NODE_MODULE_VERSION` into the section for major releases as it should only be updated for a major release. Add a note to remove the `-pre` suffix from the registry for the release commit. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39560 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #39561 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #39583 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
PR-URL: #39532 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
PR-URL: #39491 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ignore all markdown files when determining if test-asan, coverage-*, and test-macos need to run. Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths PR-URL: #39565 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
The email address for Weijia Wang in the AUTHORS and .mailmap files is different from the email address in the README.md file. Based on their GitHub profile and commit metadata, the one in the README.md file is the preferred email. Updating .mailmap and AUTHORS to reflect it. PR-URL: #39505 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Fixes doc build warnings: ``` Failed to add alternative version links to webstreams Failed to add alternative version links to async_context ``` PR-URL: #39575 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: #39584 (comment) PR-URL: #39586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
added
meta
danielleadams
removed
doc
|
@nodejs/releasers are there any other notable changes to be added? |
This comment has been minimized.
This comment has been minimized.
danielleadams
force-pushed
the
v16.7.0-proposal
branch
from
eb1a14c to
bb06ce8
Compare
This comment has been minimized.
This comment has been minimized.
nit: |
danielleadams
force-pushed
the
v16.7.0-proposal
branch
from
bb06ce8 to
d5987f8
Compare
|
Maybe it's not to late to pull this #39681? 🙂 |
|
@bricss Going to try to get the CI passing, but it's getting a little late. We have another release on 8/24 (next Tuesday), so it'll go once it lands in master, it'll be out pretty quickly after with the next release. |
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 18, 2021
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-08-17, Version 16.7.0 (Current), @danielleadams
Notable Changes
Commits
a80c989306] - async_hooks: merge resource_symbol with owner_symbol (Darshan Sen) #3846869a2a6b6c3] - bootstrap: call _undestroy() inside _destroy for stdout and stderr (Matteo Collina) #396855bc31ea0aa] - buffer: add endings option, remove Node.js specific encoding option (James M Snell) #39708091a579275] - (SEMVER-MINOR) buffer: add Blob.prototype.stream method and other cleanups (James M Snell) #39693097d898e58] - build: run coverage for inspector protocol changes (Richard Lau) #39725cf028df0ed] - build: fix V8 build with pointer compression (Michaël Zasso) #396649d38400de1] - build: exclude markdown files from some GitHub Actions (Rich Trott) #39565eeb804a7b7] - build: use lts shorthand in GitHub Actions (Rich Trott) #3953893a904d0ba] - (SEMVER-MINOR) crypto: implement webcrypto.randomUUID (Michaël Zasso) #396483321b65a5a] - debugger: prevent simultaneous heap snapshots (Rich Trott) #396386c375e18b6] - debugger: remove undefined parameter (Rich Trott) #39570103bf20988] - deps: V8: cherry-pick 81814ed44574 (Stephen Belanger) #39719cf5e5b5711] - deps: upgrade to libuv 1.42.0 (Luigi Pinca) #395255f92d2fe6d] - dgram: use simplified validator (Voltrex) #39753c7e918b06a] - (SEMVER-MINOR) dns: add "tries" option to Resolve options (Luan Devecchi) #396105d66646b71] - doc: correct cjs code to match mjs code (Raz Luvaton) #39509f18bb2a0f1] - doc: fix typo in hmac.paramNames default (Justin) #39766338a166e83] - doc: fixfs.rmdirrecursiveoption deprecation history (Antoine du Hamel) #39728bfb1dc0a2c] - doc: fixed variable names in queueMicrotask example (ashish maurya) #3963408b31f12f8] - doc: change "Version 4 UUID" to "version 4 UUID" (Tobias Nießen) #39682f5200f9785] - doc: update debugger.md description and examples (Rich Trott) #396614700f1e529] - doc: fix color contrast issue in light mode (Rich Trott) #3966088c83a4698] - (SEMVER-MINOR) doc: add missing change to resolver ctor (Luan Devecchi) #39610760cafa5ed] - doc: fix typo inurl.md(Howie Zhao) #396669ab5503693] - doc: add point to ask H1 reporter about credit (Daniel Bevenius) #395857514405456] - doc: update min mac ver + move mac arm64 to tier 1 (Ash Cripps) #39586d7c8c6dcee] - doc: add missingintroduced_inmetadata (Richard Lau) #395758072517097] - doc: add code examples toWritable.destroy()andWritable.destroyed(Juan José Arboleda) #3949155f47cc2d0] - doc: addString.prototype.atand%TypedArray%.prototype.at(Jordan Harband) #395830c0412e2c4] - doc: moveNODE_MODULE_VERSIONin release guide (Richard Lau) #395445df74f9b21] - doc: remove outdated ARM information from release guide (Richard Lau) #395448eccb11ea0] - doc: fence command examples in release guide (Richard Lau) #395440bd97e1f2d] - doc: update backport labels in release guide (Richard Lau) #395442129ad6a0a] - doc: add code example tofs.truncatemethod (Juan José Arboleda) #394543ff5e153ef] - doc: add code example tohttp.createServermethod (Juan José Arboleda) #394557d0c869cfa] - doc: add PerformanceObserverbuffereddocument (legendecas) #395140dc167a03f] - (SEMVER-MINOR) fs: add recursive cp method (Benjamin Coe) #3937254dd3df943] - http: decodes url.username and url.password for authorization header (Lew Gordon) #3931081e62f67bf] - inspector: update inspector_protocol to 89c4adf (Rich Trott) #39650793fee4915] - inspector: update inspector_protocol to 8ec18cf (Rich Trott) #396145afdc1f4c0] - lib: simplify validators (Voltrex) #39753ca3cb96d25] - lib: cleanup validation (Voltrex) #39652cc08d3062f] - lib: cleanup instance validation (Voltrex) #396562751cdf6f9] - lib: use helper for readability (Voltrex) #39649c68415cba2] - lib: use validators (Voltrex) #39663be2d60dd1d] - lib: use validator (Voltrex) #39547486d51ac0c] - lib: usevalidateObject(Voltrex) #39605058e882a2a] - lib: use ERR_ILLEGAL_CONSTRUCTOR (Mestery) #3955607cadc4432] - meta: consolidate AUTHORS entries for ooHmartY (Rich Trott) #397056c788b8030] - meta: consolidate AUTHORS entries for homosaur (Rich Trott) #3970507351edebe] - meta: consolidate AUTHORS entries for Ayase-252 (Rich Trott) #397055fe282769b] - meta: consolidate AUTHORS entries for robin-drexler (Rich Trott) #39705fc2a626357] - meta: consolidate AUTHORS entries for samshull (Rich Trott) #3970567cfc66a47] - meta: update AUTHORS (Rich Trott) #3970591008fbdeb] - meta: consolidate email addresses for MarshallOfSound (Rich Trott) #39651a76b63536a] - meta: consolidate email addresses for tadjik1 (Rich Trott) #39651aaab2095db] - meta: consolidate email addresses for szmarczak (Rich Trott) #39651f413a9d83c] - meta: update AUTHORS (Rich Trott) #396367a91d4bfe9] - meta: simplify mailmap (Rich Trott) #396124ec5d2de5d] - meta: consolidate emails for tadhgcreedon (Rich Trott) #39611bb88c38eac] - meta: consolidate emails for timcosta (Rich Trott) #396110920a8cf6f] - meta: consolidate emails for timruffles (Rich Trott) #396111474a9d4b1] - meta: update AUTHORS (Rich Trott) #39629c59e3ec685] - meta: add mailmap entry for ryzokuken (Rich Trott) #3959634f4bb8277] - meta: add mailmap entry for uttampawar (Rich Trott) #39596fd213edda2] - meta: add mailmap entry for dmabupt (Rich Trott) #395966b664e224b] - meta: align README/.mailmap/AUTHORS email entries (Rich Trott) #3950596d8ecbd66] - meta: add mailmap entry for garygsc (Rich Trott) #3958816d85f3f48] - meta: add mailmap entry for ttzztztz (Rich Trott) #3958860ab111fdb] - meta: update AUTHORS (Rich Trott) #39587b43f87d729] - meta: update .mailmap to remove duplication in AUTHORS (Rich Trott) #395616f4a2aa5a4] - meta: add .mailmap entries to remove AUTHORS duplicates (Rich Trott) #3956086d144c500] - meta: add .mailmap entry to remove duplication in AUTHORS (Rich Trott) #39559110c088f02] - meta: update collaborator email in AUTHORS/.mailmap (Rich Trott) #3952172af147bb5] - meta: update collaborator email in README (Rich Trott) #3952123bc4cfb21] - meta: update collaborator email in AUTHORS/.mailmap (Rich Trott) #39521e4289728c7] - meta: move gdams to emeritus (Rich Trott) #395394df59bc727] - module: add some typings tointernal/modules/esm/resolve(Antoine du Hamel) #39504b5858589d0] - node-api: handle pending exception in cb wrapper (Michael Dawson) #39476016b7ba616] - perf_hooks: fix PerformanceObserver gc crash (James M Snell) #39550b37575b67c] - perf_hooks: fix performance timeline wpt failures (legendecas) #3953264c02eb3cc] - (SEMVER-MINOR) perf_hooks: web performance timeline compliance (legendecas) #392977ff21397d6] - policy: fix integrity when DEFAULT_ENCODING is set (Tobias Nießen) #3975003be967cad] - src: fix TextDecoder final flush size calculation (James M Snell) #397379046e78943] - src: fix crash in AfterGetAddrInfo (Anna Henningsen) #397352a00ef5ede] - (SEMVER-MINOR) src: fix align in cares_wrap.h (Luan) #3961060a2b31c68] - src: add cosmetic space character toasync_wrap.hfile (Juan José Arboleda) #39459cd9b0bf68c] - stream: ensure text() stream consumer flushes correctly (James M Snell) #39737f57a0e4d8b] - (SEMVER-MINOR) stream: utility consumers for web and node.js streams (James M Snell) #39594975edf5330] - stream: cleanendWritableNT(Mestery) #396459e38fc6757] - (SEMVER-MINOR) stream: add readableDidRead if has been read from (Robert Nagy) #39589a5ded4a85a] - test: use simplfied validator (voltrexmaster) #3975353cf53c95a] - (SEMVER-MINOR) test: enable blob.prototype.stream tests (James M Snell) #396937e9884598f] - test: update WPT abort tests (Michaël Zasso) #3969794381fbdf5] - test: update WPT common and resources (Michaël Zasso) #3969734a041a846] - test: fix test-debugger-heap-profiler for workers (Richard Lau) #396879f5acfa90e] - test: increase memory for coverage action (Benjamin Coe) #396900be15cedc4] - test: use template to concatenate string (Himadri Ganguly) #39621952a5282e2] - (SEMVER-MINOR) test: pull Web Platform Tests for WebCryptoAPI (Michaël Zasso) #396483622fb1e03] - test: deflake test-http2-buffersize (Luigi Pinca) #395911962c7c7b3] - test: convert anonymous function to arrow function (Himadri Ganguly) #39604635e1a0274] - test: add test-debugger-breakpoint-exists (Rich Trott) #39570cff2aea5df] - test: add known issues test for debugger heap snapshot race (Rich Trott) #395575e1011238a] - tools: bump remark-preset-lint-node to 3.0.0 (Rich Trott) #39755eb741253fd] - tools: update path-parse in markdown linter package-lock file (Rich Trott) #3972952a172f983] - tools: fix more build warnings in inspector_protocol (Richard Lau) #3972577f9c1fa98] - tools: cherry-pick ffb34b6 (Darshan Sen) #39725b9510d21c9] - tools: update inspector_protocol to e8ba1a7 (Rich Trott) #396948d509d8773] - tools: update inspector_protocol to 39ca567 (Rich Trott) #39694ee7142fa37] - tools: update inspector_protocol to 97d3146 (Rich Trott) #39694c6323d847d] - Revert "tools: fix compiler warning in inspector_protocol" (Rich Trott) #396946e19c166e4] - tools: update inspector_protocol to a53e96d31a2755eb16ca37 (Rich Trott) #3969461c53f39d2] - tools: update inspector_protocol to fe0467fd105a (Rich Trott) #39694b1b6f20353] - tools: improve error detection in find-inactive-collaborators (Rich Trott) #39617d1360fcf48] - tools: update ESLint to 7.32.0 (Luigi Pinca) #39602af1c782cad] - tools: update ESLint to 7.31.0 (Colin Ihrig) #3942437dda19461] - (SEMVER-MINOR) url,buffer: implement URL.createObjectURL (James M Snell) #39693dcab88ad38] - worker: add brand checks for detached properties/methods (James M Snell) #39763