Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor spelling errors in URL documents #39666

Closed
wants to merge 1 commit into from
Closed

Fix minor spelling errors in URL documents #39666

wants to merge 1 commit into from

Conversation

howiezhao
Copy link
Contributor

The example code uses the myURL variable on the previous line, and the same variable should be used on the next line

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Aug 5, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021

Fast-track has been requested by @aduh95. Please 👍 to approve.

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution, @howiezhao. It would be great if you could change the commit message according to our guidelines by force-pushing the commit with the correct commit message. However, we can also fix this while merging your commit.

PR-URL: #39666
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@aduh95
Copy link
Contributor

aduh95 commented Aug 5, 2021

Landed in 8bfb4b9, thanks for the contribution 🎉

@aduh95 aduh95 closed this Aug 5, 2021
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39666
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@howiezhao howiezhao deleted the patch-1 branch August 19, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants