Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: implement webcrypto.randomUUID #39648

Closed
wants to merge 3 commits into from
Closed

crypto: implement webcrypto.randomUUID #39648

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 3, 2021

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 3, 2021
@targos
Copy link
Member Author

targos commented Aug 3, 2021

/cc @bcoe

tniessen
tniessen reviewed Aug 3, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR intentionally add the Web Crypto WPTs? If so, that seems like a major change regardless of randomUUID support and should probably be at least mentioned in the commit message, or separated from the change (e.g., in a separate commit).

benjamingr
benjamingr approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with Tobias's comment - I'd prefer that to be a separate commit though not blocking/a huge deal to me. (I agree it's bigger than re-exposing randomUUID on webcrypto.randomUUID)

@targos
Copy link
Member Author

targos commented Aug 4, 2021

Split into two commits

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39450/

@targos
Copy link
Member Author

targos commented Aug 4, 2021

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/28216/testReport/junit/(root)/test/wpt_test_webcrypto/

Need to skip without SSL

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39452/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39454/

tniessen
tniessen approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the changes into separate commits.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39458/

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 5, 2021
targos added a commit that referenced this pull request Aug 5, 2021
@targos
crypto: implement webcrypto.randomUUID
9073603 
Refs: https://wicg.github.io/uuid/
Refs: https://www.chromestatus.com/feature/5689159362543616

PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit that referenced this pull request Aug 5, 2021
@targos
test: pull Web Platform Tests for WebCryptoAPI
0220497 
PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos
Copy link
Member Author

targos commented Aug 5, 2021

Landed in 58316e2...0220497

@targos targos closed this Aug 5, 2021
@targos targos deleted the webcrypto-randomuuid branch August 5, 2021 14:53
@bcoe
Copy link
Contributor

bcoe commented Aug 5, 2021

@targos awesome 🥳

danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@targos @danielleadams
crypto: implement webcrypto.randomUUID
93a904d 
Refs: https://wicg.github.io/uuid/
Refs: https://www.chromestatus.com/feature/5689159362543616

PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@targos @danielleadams
test: pull Web Platform Tests for WebCryptoAPI
952a528 
PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @bcoe @jasnell @benjamingr @tniessen @aduh95