stream: add bytesRead property for readable #4372
Conversation
mscdex
added
stream
|
I'm cool w/ the change, but there a test that can be added? Also should probably be accompanied by a docs addition. |
|
Thanks, @trevnorris , I'd like to add test and docs. |
JacksonTian
force-pushed
the
bytes_read
branch
3 times, most recently
from
05727c1
to
d559dd7
Compare
|
Add test cases and docs. |
|
|
||
| var Readable = require('stream').Readable; | ||
| var Duplex = require('stream').Duplex; | ||
| var Transform = require('stream').Transform; |
There was a problem hiding this comment.
Preempting the request from others to make these const
EDIT: and anywhere else that the variable doesn't change.
|
Few comments but LGTM otherwise. |
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly.
JacksonTian
force-pushed
the
bytes_read
branch
from
d559dd7
to
9a2a446
Compare
|
Thanks @trevnorris , I updated by your suggestion. |
|
LGTM |
1 similar comment
|
LGTM |
|
Really looking forward to this 👍 |
|
LGTM. Getting a fresh CI run: https://ci.nodejs.org/job/node-test-pull-request/1234/ |
|
Failures in CI look unrelated |
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly. PR-URL: #4372 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in bfb2cd0 |
| @@ -135,6 +137,7 @@ function readableAddChunk(stream, state, chunk, encoding, addToFront) { | |||
| var e = new Error('stream.unshift() after end event'); | |||
| stream.emit('error', e); | |||
| } else { | |||
| stream.bytesRead += state.objectMode ? 0 : chunk.length; | |||
There was a problem hiding this comment.
Are you really sure this tracks bytes and not characters?
There was a problem hiding this comment.
There is an edge case, when encoding of this.push(string) is same as encoding readable, the string was just pass though.
There was a problem hiding this comment.
Sounds like a bit of a problem then? :(
There was a problem hiding this comment.
Do we need to revert this?
This reverts commit bfb2cd0. Refs: nodejs#4372
Fishrock123
added
dont-land-on-v5.x
and removed
semver-major
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly. PR-URL: nodejs#4372 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This reverts commit bfb2cd0. The bytesRead property, as implemented, tracks characters instead of bytes when using an identity encoding. Refs: nodejs#4372 PR-URL: nodejs#4746 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Add a bytesRead property for readable is
useful in some use cases.
When user want know how many bytes read of
readable, need to caculate it in userland.
If encoding is specificed, get the value is
very slowly.