Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "stream: add bytesRead property for readable" #4746

Closed
wants to merge 1 commit into from
Closed

Revert "stream: add bytesRead property for readable" #4746

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 18, 2016

This reverts commit bfb2cd0.

Refs: #4372

R= @bnoordhuis

@Fishrock123
Copy link
Contributor

cc @jasnell also, who landed it.

@bnoordhuis
Copy link
Member

LGTM but the body of the commit log should explain why it got reverted. Something like: "The property tracks characters instead of bytes when using an identity encoding."

@jasnell
Copy link
Member

jasnell commented Jan 18, 2016

LGTM

@jasnell jasnell added the stream Issues and PRs related to the stream subsystem. label Jan 18, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 18, 2016

+10 to adding reason(s) when reverting commits.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 18, 2016

I'l update the commit log before I land it.

CI: https://ci.nodejs.org/job/node-test-pull-request/1297/

cjihrig added a commit that referenced this pull request Jan 18, 2016
@cjihrig
Revert "stream: add bytesRead property for readable"
eee9dc7 
This reverts commit bfb2cd0.

The bytesRead property, as implemented, tracks characters
instead of bytes when using an identity encoding.

Refs: #4372
PR-URL: #4746
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 18, 2016

Revert landed in eee9dc7.

@cjihrig cjihrig closed this Jan 18, 2016
@cjihrig cjihrig deleted the revert branch January 18, 2016 18:18
@rvagg
Copy link
Member

rvagg commented Jan 25, 2016

added dont-land-on-v5.x and dont-land-on-v4.x because it's reverting a semver-major, please correct me if I've read this wrong.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 25, 2016

@rvagg that sounds correct.

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig
Revert "stream: add bytesRead property for readable"
234c320 
This reverts commit bfb2cd0.

The bytesRead property, as implemented, tracks characters
instead of bytes when using an identity encoding.

Refs: nodejs#4372
PR-URL: nodejs#4746
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 16, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @Fishrock123 @bnoordhuis @jasnell @mscdex @rvagg