Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 5.6.1 #43752

Closed
wants to merge 1 commit into from
Closed

deps: update undici to 5.6.1 #43752

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 10, 2022

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 10, 2022
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 10, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Jul 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Jul 10, 2022

Refs: #43661

@Trott Trott force-pushed the actions/tools-update-undici branch from 528d01b to cb402ef Compare July 10, 2022 00:48
@Trott Trott changed the title dpes: update undici to 5.6.1 deps: update undici to 5.6.1 Jul 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45244/

@aduh95
Copy link
Contributor

aduh95 commented Jul 10, 2022

@nodejs/undici it looks like this update makes WASM WPT tests fail, can you take a look?

@KhafraDev
Copy link
Member

Will fix this issue; definitely a regression.

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Jul 10, 2022
@Trott
Copy link
Member Author

Trott commented Jul 10, 2022

Will fix this issue; definitely a regression.

Guess we should close this and wait for 5.6.2.

@Trott Trott closed this Jul 10, 2022
@KhafraDev KhafraDev mentioned this pull request Jul 10, 2022
Merged
@Trott Trott deleted the actions/tools-update-undici branch July 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @aduh95 @KhafraDev @tniessen