Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Headers): lowercase name in Headers.prototype.set #1535

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

KhafraDev
Copy link
Member

Fixes a regression in a WPT from nodejs/node#43752

This is only an issue in Headers.prototype.set when using a header name that contains uppercase characters.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #1535 (38e0d1f) into main (aa8782c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1535   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          50       50           
  Lines        4609     4610    +1     
=======================================
+ Hits         4374     4375    +1     
  Misses        235      235           
Impacted Files Coverage Δ
lib/fetch/headers.js 94.44% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8782c...38e0d1f. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4340f0b into nodejs:main Jul 10, 2022
@KhafraDev KhafraDev deleted the lowercase-headers-set branch July 10, 2022 18:12
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants