Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix remaining WebCryptoAPI idlharness WPTs #45857

Closed
wants to merge 3 commits into from
Closed

crypto: fix remaining WebCryptoAPI idlharness WPTs #45857

wants to merge 3 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Dec 14, 2022 •
edited
Loading

Refactor Cryptokey to be just a non-constructable wrapper, not having any of the transferable related getters, moving those to InternalCryptoKey.

JSTransferable remains in effect, but will rebase and run ci after #45811 lands to reconfirm (done).

Also fixes (adds) globalThis.crypto this check.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Dec 14, 2022
@panva panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 14, 2022
@panva panva force-pushed the fix-cryptokey-prototype branch from 840aac6 to b5e59e3 Compare December 16, 2022 13:24
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 16, 2022
@panva panva requested a review from jasnell December 16, 2022 19:55
@panva panva force-pushed the fix-cryptokey-prototype branch from b5e59e3 to b9a06a0 Compare December 16, 2022 19:56
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 16, 2022
@panva panva changed the title crypto: fix CryptoKey prototype WPT crypto: fix remaining WebCryptoAPI idlharness WPTs Dec 16, 2022
@panva panva requested review from aduh95 and joyeecheung December 16, 2022 20:08
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Dec 17, 2022
View reviewed changes
lib/internal/util.js Outdated Show resolved Hide resolved
@panva panva force-pushed the fix-cryptokey-prototype branch from d864774 to dc6e9a8 Compare December 17, 2022 19:31
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7738844...3f3966c

nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
@panva @nodejs-github-bot
crypto: fix CryptoKey prototype WPT
560b243 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
@panva @nodejs-github-bot
test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals
e8b56fb 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
@panva @nodejs-github-bot
crypto: fix globalThis.crypto this check
3f3966c 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2022
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
crypto: fix CryptoKey prototype WPT
90218b8 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals
469a9a0 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
crypto: fix globalThis.crypto this check
0dffe56 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
@panva panva deleted the fix-cryptokey-prototype branch January 2, 2023 22:07
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@panva @RafaelGSS
crypto: fix CryptoKey prototype WPT
8bd40d1 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@panva @RafaelGSS
test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals
43605af 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@panva @RafaelGSS
crypto: fix globalThis.crypto this check
4b28ee6 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@panva @RafaelGSS
crypto: fix CryptoKey prototype WPT
56f3ad1 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@panva @RafaelGSS
test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals
97a8e05 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@panva @RafaelGSS
crypto: fix globalThis.crypto this check
f7dba5b 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol
Copy link
Member

Depends on #45659

@juanarbol juanarbol added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Jan 22, 2023
@panva
Copy link
Member Author

panva commented Jan 23, 2023

Backport of #45659 seems unlikely and even if, with webcrypto not being global yet in 18.x backporting this one (#45857) would not be of much use to anyone.

@aduh95 aduh95 added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Jan 23, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva @juanarbol
crypto: fix CryptoKey prototype WPT
7a97f3f 
PR-URL: #45857
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @juanarbol @jasnell @aduh95