Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.4.0 proposal #46061

Merged
merged 120 commits into from
Jan 6, 2023
Merged

v19.4.0 proposal #46061

merged 120 commits into from
Jan 6, 2023

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jan 2, 2023

2023-01-06, Version 19.4.0 (Current), @RafaelGSS

Notable Changes

  • buffer:
    • (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
  • http:
    • (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
  • net:
    • add autoSelectFamily global getter and setter (Paolo Insogna) #45777
  • os:
    • (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
  • util:
    • add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

Commits

  • [54b748acc0] - async_hooks: refactor to use validateObject (Deokjin Kim) #46004
  • [cf2ff81f26] - benchmark: include webstreams benchmark (Rafael Gonzaga) #45876
  • [6e3d7f8c2d] - bootstrap: optimize modules loaded in the built-in snapshot (Joyee Cheung) #45849
  • [d181b76374] - bootstrap: make CJS loader snapshotable (Joyee Cheung) #45849
  • [508e830765] - bootstrap: include event_target into the built-in snapshot (Joyee Cheung) #45849
  • [dd77c05480] - bootstrap: support module_wrap binding in snapshot (Joyee Cheung) #45849
  • [fbe399c75c] - (SEMVER-MINOR) buffer: add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
  • [233a66f937] - build: fix arm64 cross-compile from powershell (Stefan Stojanovic) #45890
  • [e7b98a3da2] - build: add option to disable shared readonly heap (Anna Henningsen) #45887
  • [777c551edf] - crypto: ensure exported webcrypto EC keys use uncompressed point format (Ben Noordhuis) #46021
  • [f7dba5bef7] - crypto: fix globalThis.crypto this check (Filip Skokan) #45857
  • [56f3ad101b] - crypto: fix CryptoKey prototype WPT (Filip Skokan) #45857
  • [c9747f1140] - crypto: use globalThis.crypto over require('crypto').webcrypto (Filip Skokan) #45817
  • [6eede72241] - crypto: fix CryptoKey WebIDL conformance (Filip Skokan) #45855
  • [c9802862b7] - crypto: fix error when getRandomValues is called without arguments (Filip Skokan) #45854
  • [3d09754186] - debugger: refactor console in lib/internal/debugger/inspect.js (Debadree Chatterjee) #45847
  • [fdda2ff53b] - deps: V8: cherry-pick 30861a39323d (Aaron Friel) #45851
  • [71bf513062] - deps: patch V8 to 10.8.168.25 (Michaël Zasso) #45996
  • [0552b13232] - deps: update simdutf to 2.0.9 (Node.js GitHub Bot) #45975
  • [e73be1b3b9] - deps: update to uvwasi 0.0.14 (Colin Ihrig) #45970
  • [e4323f01c1] - deps: fix updater github workflow job (Yagiz Nizipli) #45972
  • [05fee67238] - Revert "deps: disable avx512 for simutf on benchmark ci" (Yagiz Nizipli) #45948
  • [98fc94a444] - deps: disable avx512 for simutf on benchmark ci (Yagiz Nizipli) #45803
  • [344c5ec0ea] - deps: add simdutf dependency (Yagiz Nizipli) #45803
  • [7bdad948c8] - deps: V8: backport 8ca9f77d0f7c (Anna Henningsen) #45871
  • [29f90cf5af] - deps: update timezone to 2022g (Node.js GitHub Bot) #45731
  • [99fec0bf64] - deps: update undici to 5.14.0 (Node.js GitHub Bot) #45812
  • [faee973fa7] - deps: V8: cherry-pick bc831f8ba33b (Yagiz Nizipli) #45788
  • [e2944109c6] - deps: V8: cherry-pick bf0bd4868dde (Michaël Zasso) #45908
  • [e113d169ee] - doc: update isUtf8 description (Yagiz Nizipli) #45973
  • [9e16406066] - doc: sort http.createServer() options alphabetically (Luigi Pinca) #45680
  • [49253e1a8f] - doc: use console.error for error case in timers and tls (Deokjin Kim) #46002
  • [8be1b666a7] - doc: fix wrong output of example in url.protocol (Deokjin Kim) #45954
  • [9251dce8b2] - doc: use os.availableParallelism() in async_context and cluster (Deokjin Kim) #45979
  • [952e03ae66] - doc: make EventEmitterAsyncResource's options as optional (Deokjin Kim) #45985
  • [71cc3b3712] - doc: replace single executable champion in strategic initiatives doc (Darshan Sen) #45956
  • [eaf6b63637] - doc: update error message of example in repl (Deokjin Kim) #45920
  • [d8b5b7da75] - doc: fix typos in packages.md (Eric Mutta) #45957
  • [4457e051c9] - doc: remove port from example in url.hostname (Deokjin Kim) #45927
  • [908f4fab52] - doc: show output of example in http (Deokjin Kim) #45915
  • [faf5c23084] - (SEMVER-MINOR) doc: add parallelism note to os.cpus() (Colin Ihrig) #45895
  • [9ed547b73c] - doc: fix wrong output of example in url.password (Deokjin Kim) #45928
  • [a89f8c1337] - doc: fix some history entries in deprecations.md (Antoine du Hamel) #45891
  • [cf30fca23f] - doc: add tip for NODE_MODULE (theanarkh) #45797
  • [d500445aec] - doc: reduce likelihood of mismerges during release (Richard Lau) #45864
  • [e229f060e3] - doc: add backticks to webcrypto rsaOaepParams (Filip Skokan) #45883
  • [dfa58c1947] - doc: remove release cleanup step (Michaël Zasso) #45858
  • [b93a9670a8] - doc: add stream/promises pipeline and finished to doc (Marco Ippolito) #45832
  • [c86f4a17d6] - doc: remove Juan Jose keys (Rafael Gonzaga) #45827
  • [c37a119f90] - doc: remove last example use of require('crypto').webcrypto (Filip Skokan) #45819
  • [7e047dfcbb] - doc: fix wrong output of example in util (Deokjin Kim) #45825
  • [8046e0ef53] - errors: refactor to use a method that formats a list string (Daeyeon Jeong) #45793
  • [2d49e0e635] - esm: rewrite loader hooks test (Geoffrey Booth) #46016
  • [47cc0e4bdb] - events: fix violation of symbol naming convention (Deokjin Kim) #45978
  • [22a66cff66] - fs: refactor to use validateInteger (Deokjin Kim) #46008
  • [bc43922949] - http: replace var with const on code of comment (Deokjin Kim) #45951
  • [7ea72ee421] - (SEMVER-MINOR) http: improved timeout defaults handling (Paolo Insogna) #45778
  • [7f1daedf4c] - lib: update JSDoc of getOwnPropertyValueOrDefault (Deokjin Kim) #46010
  • [28f9089b83] - lib: use kEmptyObject as default value for options (Deokjin Kim) #46011
  • [f6c6673ec4] - lib: lazy-load deps in modules/run_main.js (Joyee Cheung) #45849
  • [e529ea4144] - lib: lazy-load deps in source_map_cache.js (Joyee Cheung) #45849
  • [943852ab83] - lib: add getLazy() method to internal/util (Joyee Cheung) #45849
  • [25d0a94453] - meta: update AUTHORS (Node.js GitHub Bot) #46040
  • [0a70316ecc] - meta: update AUTHORS (Node.js GitHub Bot) #45968
  • [86e30fcb4d] - meta: add nodejs/loaders to CODEOWNERS (Geoffrey Booth) #45940
  • [e95695654d] - meta: add nodejs/test_runner to CODEOWNERS (Antoine du Hamel) #45935
  • [353dab5bdf] - meta: update AUTHORS (Node.js GitHub Bot) #45899
  • [0b3512f690] - modules: move callbacks and conditions into modules/esm/utils.js (Joyee Cheung) #45849
  • [c6ab449d1b] - modules: move modules/cjs/helpers.js to modules/helpers.js (Joyee Cheung) #45849
  • [4d62b099b4] - net: handle socket.write(cb) edge case (Santiago Gimeno) #45922
  • [8e6b8dbb41] - net: add autoSelectFamily global getter and setter (Paolo Insogna) #45777
  • [f3bb6a38ae] - node-api: generalize finalizer second pass callback (Chengzhong Wu) #44141
  • [d71883e271] - (SEMVER-MINOR) os: add availableParallelism() (Colin Ihrig) #45895
  • [4c0850539a] - process,worker: ensure code after exit() effectless (ywave620) #45620
  • [24cae6b4a3] - repl: improve robustness wrt to prototype pollution (Antoine du Hamel) #45604
  • [af25c95b22] - src: fix typo in node_file.cc (Vadim) #45998
  • [261d6d0726] - src: fix crash on OnStreamRead on Windows (Santiago Gimeno) #45878
  • [6c5b7e660b] - src: add worker per-isolate binding initialization (Chengzhong Wu) #45547
  • [db535b6caa] - src: define per-isolate internal bindings registration callback (Chengzhong Wu) #45547
  • [ded87f6dc4] - src: fix creating Isolates from addons (Anna Henningsen) #45885
  • [c2ed0ccb28] - src: use string_view for FastStringKey implementation (Anna Henningsen) #45914
  • [b995138b96] - src: use CreateEnvironment instead of inlining its code where possible (Anna Henningsen) #45886
  • [4454f5fd71] - src: fix UB in overflow checks (Ben Noordhuis) #45882
  • [27d3201502] - src: check size of args before using for exec_path (A. Wilcox) #45902
  • [2f898f2983] - src: fix tls certificate root store data race (Ben Noordhuis) #45767
  • [eff92a61b9] - src: add undici and acorn to process.versions (Debadree Chatterjee) #45621
  • [ab22a8ff4b] - stream: refactor to use validateFunction (Deokjin Kim) #46007
  • [0858956f5f] - stream: fix typo in JSDoc (Deokjin Kim) #45991
  • [2807efaea6] - test: use process.hrtime.bigint instead of process.hrtime (Deokjin Kim) #45877
  • [0f5a145973] - test: print failed JS/parallel tests (Geoffrey Booth) #45960
  • [c6c094702b] - test: split parallel fs-watch-recursive tests (Yagiz Nizipli) #45865
  • [97a8e055be] - test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals (Filip Skokan) #45857
  • [95ce16d8d9] - test: fix test broken under --node-builtin-modules-path (Geoffrey Booth) #45894
  • [97868befe7] - test: fix mock.method to support class instances (Erick Wendel) #45608
  • [71056daf76] - test: update encoding wpt to latest (Yagiz Nizipli) #45850
  • [10367c4cae] - test: update url wpt to latest (Yagiz Nizipli) #45852
  • [53f02cf631] - test: add CryptoKey transferring tests (Filip Skokan) #45811
  • [5de08ef275] - test: add postject to fixtures (Darshan Sen) #45298
  • [fea122d51e] - test: enable idlharness WebCryptoAPI WPTs (Filip Skokan) #45822
  • [3c2ce5635e] - test: remove use of --experimental-global-webcrypto flag (Filip Skokan) #45816
  • [b5e124537e] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #45860
  • [7ae24abd7b] - test_runner: use os.availableParallelism() (Colin Ihrig) #45969
  • [c5004d42af] - test_runner: run t.after() if test body throws (Colin Ihrig) #45870
  • [bdbb676bee] - test_runner: parse yaml (Moshe Atlow) #45815
  • [ca9b9b9ce6] - tls: don't treat fatal TLS alerts as EOF (David Benjamin) #44563
  • [d08a574ecf] - tls: fix re-entrancy issue with TLS close_notify (David Benjamin) #44563
  • [0f0d22a63e] - tools: update lint-md-dependencies to rollup@3.9.0 (Node.js GitHub Bot) #46039
  • [5a8d125fc4] - tools: update doc to unist-util-select@4.0.2 (Node.js GitHub Bot) #46038
  • [54776ffe80] - tools: add release host var to promotion script (Ruy Adorno) #45913
  • [f968fdb78a] - tools: add url to AUTHORS update automation (Antoine du Hamel) #45971
  • [7c518cbac1] - tools: update lint-md-dependencies to rollup@3.8.1 (Node.js GitHub Bot) #45967
  • [1282f7f656] - tools: update GitHub workflow action (Mohammed Keyvanzadeh) #45937
  • [f446af78e9] - tools: update lint-md dependencies (Node.js GitHub Bot) #45813
  • [794611ade9] - tools: enforce use of trailing commas in tools/ (Antoine du Hamel) #45889
  • [124c2b32d9] - tools: fix incorrect version history order (Fabien Michel) #45728
  • [27cf389c22] - tools: update eslint to 8.29.0 (Node.js GitHub Bot) #45733
  • [ae842a40b5] - util: add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803
  • [389cc3e1d6] - vm: refactor to use validateStringArray (Deokjin Kim) #46020
  • [7bd6a2c258] - wasi: fast calls (snek) #43697

targos and others added 30 commits December 28, 2022 08:17
Original commit message:

    [fastcall] Disable fast calls with stack args on M1

    Bug: v8:13171
    Change-Id: I549d942d8ae24e2de0aa3202d7400b587254fb75
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3963995
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83886}

Refs: v8/v8@bf0bd48
PR-URL: #45908
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #43697
Backport-PR-URL: #45908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:

    [fastcall] Implement support for onebyte string arguments

    This CL adds one byte string specialization support for fast API call arguments.
    It introduces a kOneByteString variant to CTypeInfo.

    We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
    Rendered results: https://divy-v8-patches.deno.dev/

    Bug: chromium:1052746
    Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#84552}

Refs: v8/v8@bc831f8
PR-URL: #45788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
In `mime.type` of util, `application/javascript` is actual output,
but described as `application/javascript/javascript`.

PR-URL: #45825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Like errno, OpenSSL's API requires SSL_get_error and error queue be
checked immediately after the failing operation, otherwise the error
queue or SSL object may have changed state and no longer report
information about the operation the caller wanted.

TLSWrap almost heeds this rule, except in TLSWrap::ClearOut. If SSL_read
picks up a closing alert (detected by checking SSL_get_shutdown), Node
calls out to JS with EmitRead(UV_EOF) and only afterwards proceeds to
dispatch on the error. But, by this point, Node has already re-entered
JS, which may change the error.

In particular, I've observed that, on close_notify, JS seems to
sometimes call back into TLSWrap::DoShutdown, calling SSL_shutdown. (I
think this comes from onStreamRead in stream_base_commons.js?)

Instead, SSL_get_error and the error queue should be sampled earlier.
Back in #1661, Node needed to account for GetSSLError being called after
ssl_ was destroyed. This was the real cause. With this fixed, there's no
need to account for this. (Any case where ssl_ may be destroyed before
SSL_get_error is a case where ssl_ or the error queue could change
state, so it's a bug either way.)

This is the first of two fixes in error-handling here. The
EmitRead(UV_EOF) seems to additionally swallow fatal alerts from the
peer. Some of the ECONNRESET expectations in the tests aren't actually
correct. The next commit will fix this as well.

PR-URL: #44563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
SSL_RECEIVED_SHUTDOWN means not just close_notify or fatal alert. From
what I can tell, this was just a mistake? OnStreamRead's comment
suggests eof_ was intended to be for close_notify.

This fixes a bug in TLSSocket error reporting that seems to have made it
into existing tests. If we receive a fatal alert, EmitRead(UV_EOF)
would, via onConnectEnd in _tls_wrap.js, synthesize an ECONNRESET before
the alert itself is surfaced. As a result, TLS alerts received during
the handshake are misreported by Node.

See the tests that had to be updated as part of this.

PR-URL: #44563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45812
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #45816
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #45819
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #45822
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45733
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: #45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45604
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #45827
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This should make it possible to test out the creation of Single
Executable Applications on a PR without making outbound requests to
download and run postject using npm.

This is needed for #45038.

Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #45298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #45832
Fixes: #45821
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Since the module has to be loaded during bootstrap anyway.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
The helpers are actually shared by the two loaders, so move them
under modules/ directly.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This patch adds a getLazy() method to facilitate initialize-once
lazy loading in the internals.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
So that the file can be snapshotted.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
So that the file can be snapshotted

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This moves the following utils into modules/esm/utils.js:

- Code related to default conditions
- The callbackMap (which is now created in the module instead of
  hanging off the module_wrap binding, since the C++ land
  does not need it).
- Per-isolate module callbacks

These are self-contained code that can be included into the
built-in snapshot.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This patch makes the top-level access to runtime states in the
CJS loader lazy, and move the side-effects into a
initializeCJS() function that gets called during pre-execution.
As a result the CJS loader can be included into the built-in
snapshot.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Preload essential modules and lazy-load non-essential ones.
After this patch, all modules listed by running this snippet:

```
const list = process.moduleLoadList.join('\n');
require('fs').writeSync(1, list, 'utf-8');
```

(which is roughly the same list as the one in
test-bootstrap-module.js for the main thread)
are loaded from the snapshot so no additional compilation cost
is incurred.

PR-URL: #45849
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #45854
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #45855
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #45860
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- The pull request is automatically closed.
- The branch is automatically deleted.

PR-URL: #45858
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot

This comment was marked as outdated.

Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@jaydenseric
Copy link
Contributor

#46061 (comment)

Commit dropped (its dependents too).

I'm desperate for these test runner reporters, so really hopeful they don't get dropped from the v19.4.0 release; been waiting with excitement for a month! Will they make it in do you think if #46092 is merged soon?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@danielleadams
Copy link
Contributor

#46061 (comment)

Commit dropped (its dependents too).

I'm desperate for these test runner reporters, so really hopeful they don't get dropped from the v19.4.0 release; been waiting with excitement for a month! Will they make it in do you think if #46092 is merged soon?

@jaydenseric they probably won't make it in this release because the proposal has already been drafted, but there will be another v19 release in 2 weeks.

@RafaelGSS RafaelGSS merged commit e58ed6d into v19.x Jan 6, 2023
RafaelGSS added a commit that referenced this pull request Jan 6, 2023
@RafaelGSS RafaelGSS deleted the v19.4.0-proposal branch January 6, 2023 12:54
RafaelGSS added a commit that referenced this pull request Jan 6, 2023
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jan 6, 2023
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jan 6, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Refs: nodejs/node#46061
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Jan 6, 2023
nodejs-github-bot pushed a commit that referenced this pull request Jan 7, 2023
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
Refs: nodejs#46061 (comment)
PR-URL: nodejs#46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@jaydenseric jaydenseric mentioned this pull request Jan 22, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.