-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update error message of example in repl #45920
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221220_update_error_msg_repl
Dec 24, 2022
Merged
doc: update error message of example in repl #45920
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221220_update_error_msg_repl
Dec 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error message in document is different from actual result.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
repl
Issues and PRs related to the REPL subsystem.
labels
Dec 20, 2022
cola119
approved these changes
Dec 21, 2022
aymen94
approved these changes
Dec 22, 2022
cola119
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Dec 22, 2022
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Dec 22, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45920 FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close at consumeBody (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Response.text (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18) at async Request.json (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18) at async Request.query (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20) at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20) at async Request.gql (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22) at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21) at async Promise.all (index 2) at async Promise.all (index 1) { type: 'system', errno: 'ERR_STREAM_PREMATURE_CLOSE', code: 'ERR_STREAM_PREMATURE_CLOSE', erroredSysCall: undefined }https://github.com/nodejs/node/actions/runs/3758639577 |
cola119
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Dec 23, 2022
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Dec 23, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45920 ✔ Done loading data for nodejs/node/pull/45920 ----------------------------------- PR info ------------------------------------ Title doc: update error message of example in repl (#45920) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:221220_update_error_msg_repl -> nodejs:main Labels doc, repl, author ready Commits 1 - doc: update error message of example in repl Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/45920 Reviewed-By: Kohei Ueno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45920 Reviewed-By: Kohei Ueno -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 20 Dec 2022 10:34:45 GMT ✔ Approvals: 1 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/45920#pullrequestreview-1225369922 ✖ This PR needs to wait 103 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3762762798 |
lpinca
approved these changes
Dec 24, 2022
lpinca
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Dec 24, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 24, 2022
Landed in 9e58e4b |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
repl
Issues and PRs related to the REPL subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message in document is different from actual result.