-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v19.4.0 proposal #46061
v19.4.0 proposal #46061
Commits on Dec 28, 2022
-
deps: V8: cherry-pick bf0bd4868dde
Original commit message: [fastcall] Disable fast calls with stack args on M1 Bug: v8:13171 Change-Id: I549d942d8ae24e2de0aa3202d7400b587254fb75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3963995 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#83886} Refs: v8/v8@bf0bd48 PR-URL: #45908 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for e294410 - Browse repository at this point
Copy the full SHA e294410View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bd6a2c - Browse repository at this point
Copy the full SHA 7bd6a2cView commit details
Commits on Jan 1, 2023
-
deps: V8: cherry-pick bc831f8ba33b
Original commit message: [fastcall] Implement support for onebyte string arguments This CL adds one byte string specialization support for fast API call arguments. It introduces a kOneByteString variant to CTypeInfo. We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark. Rendered results: https://divy-v8-patches.deno.dev/ Bug: chromium:1052746 Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#84552} Refs: v8/v8@bc831f8 PR-URL: #45788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for faee973 - Browse repository at this point
Copy the full SHA faee973View commit details -
doc: fix wrong output of example in util
In `mime.type` of util, `application/javascript` is actual output, but described as `application/javascript/javascript`. PR-URL: #45825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e047df - Browse repository at this point
Copy the full SHA 7e047dfView commit details -
tls: fix re-entrancy issue with TLS close_notify
Like errno, OpenSSL's API requires SSL_get_error and error queue be checked immediately after the failing operation, otherwise the error queue or SSL object may have changed state and no longer report information about the operation the caller wanted. TLSWrap almost heeds this rule, except in TLSWrap::ClearOut. If SSL_read picks up a closing alert (detected by checking SSL_get_shutdown), Node calls out to JS with EmitRead(UV_EOF) and only afterwards proceeds to dispatch on the error. But, by this point, Node has already re-entered JS, which may change the error. In particular, I've observed that, on close_notify, JS seems to sometimes call back into TLSWrap::DoShutdown, calling SSL_shutdown. (I think this comes from onStreamRead in stream_base_commons.js?) Instead, SSL_get_error and the error queue should be sampled earlier. Back in #1661, Node needed to account for GetSSLError being called after ssl_ was destroyed. This was the real cause. With this fixed, there's no need to account for this. (Any case where ssl_ may be destroyed before SSL_get_error is a case where ssl_ or the error queue could change state, so it's a bug either way.) This is the first of two fixes in error-handling here. The EmitRead(UV_EOF) seems to additionally swallow fatal alerts from the peer. Some of the ECONNRESET expectations in the tests aren't actually correct. The next commit will fix this as well. PR-URL: #44563 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d08a574 - Browse repository at this point
Copy the full SHA d08a574View commit details -
tls: don't treat fatal TLS alerts as EOF
SSL_RECEIVED_SHUTDOWN means not just close_notify or fatal alert. From what I can tell, this was just a mistake? OnStreamRead's comment suggests eof_ was intended to be for close_notify. This fixes a bug in TLSSocket error reporting that seems to have made it into existing tests. If we receive a fatal alert, EmitRead(UV_EOF) would, via onConnectEnd in _tls_wrap.js, synthesize an ECONNRESET before the alert itself is surfaced. As a result, TLS alerts received during the handshake are misreported by Node. See the tests that had to be updated as part of this. PR-URL: #44563 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ca9b9b9 - Browse repository at this point
Copy the full SHA ca9b9b9View commit details -
PR-URL: #45812 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 99fec0b - Browse repository at this point
Copy the full SHA 99fec0bView commit details -
test: remove use of --experimental-global-webcrypto flag
PR-URL: #45816 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c2ce56 - Browse repository at this point
Copy the full SHA 3c2ce56View commit details -
PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bdbb676 - Browse repository at this point
Copy the full SHA bdbb676View commit details -
doc: remove last example use of require('crypto').webcrypto
PR-URL: #45819 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c37a119 - Browse repository at this point
Copy the full SHA c37a119View commit details -
test: enable idlharness WebCryptoAPI WPTs
PR-URL: #45822 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fea122d - Browse repository at this point
Copy the full SHA fea122dView commit details -
tools: update eslint to 8.29.0
PR-URL: #45733 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 27cf389 - Browse repository at this point
Copy the full SHA 27cf389View commit details -
tools: fix incorrect version history order
This fixes an error in parseYAML(text), the version sorting coudn't be right as we compared an arrify string (ie. a = ["v18.11, v16.7.0"]) with an array of strings (ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b). minVersion(a) couldn't find the minimum version with an arrify string like a = ["v18.11, v16.7.0"]. That's why incorrect version history orders sometimes appeared. Furthermore, no need to sort the added version as it always comes first. So, it can be the last one to be pushed in the meta.changes array. Fixes: #45670 Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 124c2b3 - Browse repository at this point
Copy the full SHA 124c2b3View commit details -
repl: improve robustness wrt to prototype pollution
PR-URL: #45604 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 24cae6b - Browse repository at this point
Copy the full SHA 24cae6bView commit details -
PR-URL: #45827 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for c86f4a1 - Browse repository at this point
Copy the full SHA c86f4a1View commit details -
test: add postject to fixtures
This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm. This is needed for #45038. Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45298 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Configuration menu - View commit details
-
Copy full SHA for 5de08ef - Browse repository at this point
Copy the full SHA 5de08efView commit details -
Configuration menu - View commit details
-
Copy full SHA for b93a967 - Browse repository at this point
Copy the full SHA b93a967View commit details -
bootstrap: support module_wrap binding in snapshot
PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dd77c05 - Browse repository at this point
Copy the full SHA dd77c05View commit details -
bootstrap: include event_target into the built-in snapshot
Since the module has to be loaded during bootstrap anyway. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 508e830 - Browse repository at this point
Copy the full SHA 508e830View commit details -
modules: move modules/cjs/helpers.js to modules/helpers.js
The helpers are actually shared by the two loaders, so move them under modules/ directly. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6ab449 - Browse repository at this point
Copy the full SHA c6ab449View commit details -
lib: add getLazy() method to internal/util
This patch adds a getLazy() method to facilitate initialize-once lazy loading in the internals. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 943852a - Browse repository at this point
Copy the full SHA 943852aView commit details -
lib: lazy-load deps in source_map_cache.js
So that the file can be snapshotted. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e529ea4 - Browse repository at this point
Copy the full SHA e529ea4View commit details -
lib: lazy-load deps in modules/run_main.js
So that the file can be snapshotted PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f6c6673 - Browse repository at this point
Copy the full SHA f6c6673View commit details -
modules: move callbacks and conditions into modules/esm/utils.js
This moves the following utils into modules/esm/utils.js: - Code related to default conditions - The callbackMap (which is now created in the module instead of hanging off the module_wrap binding, since the C++ land does not need it). - Per-isolate module callbacks These are self-contained code that can be included into the built-in snapshot. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b3512f - Browse repository at this point
Copy the full SHA 0b3512fView commit details -
bootstrap: make CJS loader snapshotable
This patch makes the top-level access to runtime states in the CJS loader lazy, and move the side-effects into a initializeCJS() function that gets called during pre-execution. As a result the CJS loader can be included into the built-in snapshot. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d181b76 - Browse repository at this point
Copy the full SHA d181b76View commit details -
bootstrap: optimize modules loaded in the built-in snapshot
Preload essential modules and lazy-load non-essential ones. After this patch, all modules listed by running this snippet: ``` const list = process.moduleLoadList.join('\n'); require('fs').writeSync(1, list, 'utf-8'); ``` (which is roughly the same list as the one in test-bootstrap-module.js for the main thread) are loaded from the snapshot so no additional compilation cost is incurred. PR-URL: #45849 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e3d7f8 - Browse repository at this point
Copy the full SHA 6e3d7f8View commit details -
crypto: fix error when getRandomValues is called without arguments
PR-URL: #45854 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c980286 - Browse repository at this point
Copy the full SHA c980286View commit details -
crypto: fix CryptoKey WebIDL conformance
PR-URL: #45855 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 6eede72 - Browse repository at this point
Copy the full SHA 6eede72View commit details -
test,crypto: update WebCryptoAPI WPT
PR-URL: #45860 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b5e1245 - Browse repository at this point
Copy the full SHA b5e1245View commit details -
doc: remove release cleanup step
- The pull request is automatically closed. - The branch is automatically deleted. PR-URL: #45858 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dfa58c1 - Browse repository at this point
Copy the full SHA dfa58c1View commit details -
doc: add backticks to webcrypto rsaOaepParams
PR-URL: #45883 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e229f06 - Browse repository at this point
Copy the full SHA e229f06View commit details -
test: add CryptoKey transferring tests
PR-URL: #45811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53f02cf - Browse repository at this point
Copy the full SHA 53f02cfView commit details -
crypto: use globalThis.crypto over require('crypto').webcrypto
PR-URL: #45817 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c9747f1 - Browse repository at this point
Copy the full SHA c9747f1View commit details -
doc: reduce likelihood of mismerges during release
Switch to the `patience` git diff algorithm to reduce the likelihood of mismerges when the release commit is cherry-picked to the `main` branch. Refs: nodejs/Release#771 (comment) PR-URL: #45864 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for d500445 - Browse repository at this point
Copy the full SHA d500445View commit details -
test: update url wpt to latest
PR-URL: #45852 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 10367c4 - Browse repository at this point
Copy the full SHA 10367c4View commit details -
test_runner: run t.after() if test body throws
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: #45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c5004d4 - Browse repository at this point
Copy the full SHA c5004d4View commit details -
test: update encoding wpt to latest
PR-URL: #45850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71056da - Browse repository at this point
Copy the full SHA 71056daView commit details -
test: fix mock.method to support class instances
It fixes a problem when trying to spy a method from a class instance or static functions on a class instance PR-URL: #45608 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97868be - Browse repository at this point
Copy the full SHA 97868beView commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eff92a6 - Browse repository at this point
Copy the full SHA eff92a6View commit details -
tools: enforce use of trailing commas in
tools/
PR-URL: #45889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 794611a - Browse repository at this point
Copy the full SHA 794611aView commit details -
PR-URL: #45899 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 353dab5 - Browse repository at this point
Copy the full SHA 353dab5View commit details -
test: fix test broken under --node-builtin-modules-path
PR-URL: #45894 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 95ce16d - Browse repository at this point
Copy the full SHA 95ce16dView commit details -
PR-URL: #45797 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf30fca - Browse repository at this point
Copy the full SHA cf30fcaView commit details -
src: fix tls certificate root store data race
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: #45743 PR-URL: #45767 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 2f898f2 - Browse repository at this point
Copy the full SHA 2f898f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a89f8c1 - Browse repository at this point
Copy the full SHA a89f8c1View commit details -
node-api: generalize finalizer second pass callback
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for f3bb6a3 - Browse repository at this point
Copy the full SHA f3bb6a3View commit details -
tools: update lint-md dependencies
Update to @rollupw/plugin-commonjs@24.0.0 and rollup@3.7.5. PR-URL: #45813 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f446af7 - Browse repository at this point
Copy the full SHA f446af7View commit details -
deps: update timezone to 2022g
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 29f90cf - Browse repository at this point
Copy the full SHA 29f90cfView commit details -
crypto: fix CryptoKey prototype WPT
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56f3ad1 - Browse repository at this point
Copy the full SHA 56f3ad1View commit details -
test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97a8e05 - Browse repository at this point
Copy the full SHA 97a8e05View commit details -
crypto: fix globalThis.crypto this check
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f7dba5b - Browse repository at this point
Copy the full SHA f7dba5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6c0947 - Browse repository at this point
Copy the full SHA c6c0947View commit details -
src: check size of args before using for exec_path
If we are in an artifically created Environment that has no args set, and uv_exepath returns an error (for instance, if /proc is not mounted on a Linux system), then we crash with a nullptr deref attempting to use argv[0]. Fixes: #45901 PR-URL: #45902 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 27d3201 - Browse repository at this point
Copy the full SHA 27d3201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4454f5f - Browse repository at this point
Copy the full SHA 4454f5fView commit details -
deps: V8: backport 8ca9f77d0f7c
This fixes a crash when loading snapshots that contain empty ArrayBuffer instances: ```js const X = []; X.push(new ArrayBuffer()); v8.startupSnapshot.setDeserializeMainFunction(() => { for (let i = 0; i < 1000000; i++) { // trigger GC X.push(new ArrayBuffer()); } }) ``` Original commit message: [sandbox] Sandboxify JSArrayBuffer::extension external pointer Bug: chromium:1335043 Change-Id: Id8e6883fc652b144f6380ff09b1c18e777e041c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706626 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#84544} Refs: v8/v8@8ca9f77 PR-URL: #45871 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7bdad94 - Browse repository at this point
Copy the full SHA 7bdad94View commit details -
doc: fix wrong output of example in
url.password
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9ed547b - Browse repository at this point
Copy the full SHA 9ed547bView commit details -
benchmark: include webstreams benchmark
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Configuration menu - View commit details
-
Copy full SHA for cf2ff81 - Browse repository at this point
Copy the full SHA cf2ff81View commit details -
src: use CreateEnvironment instead of inlining its code where possible
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself. PR-URL: #45886 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b995138 - Browse repository at this point
Copy the full SHA b995138View commit details -
build: add option to disable shared readonly heap
PR-URL: #45887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e7b98a3 - Browse repository at this point
Copy the full SHA e7b98a3View commit details -
os: add availableParallelism()
This commit exposes uv_available_parallelism() as an alternative to cpus().length. uv_available_parallelism() is inspired by Rust's available_parallelism(). PR-URL: #45895 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for d71883e - Browse repository at this point
Copy the full SHA d71883eView commit details -
doc: add parallelism note to os.cpus()
With the introduction of os.availableParallelism(), users should no longer rely on os.cpus().length to determine the amount of available parallelism. This commit adds a note to the os.cpus() docs. PR-URL: #45895 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for faf5c23 - Browse repository at this point
Copy the full SHA faf5c23View commit details -
src: use string_view for FastStringKey implementation
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c2ed0cc - Browse repository at this point
Copy the full SHA c2ed0ccView commit details -
PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 344c5ec - Browse repository at this point
Copy the full SHA 344c5ecView commit details -
util: add fast path for text-decoder fatal flag
PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for ae842a4 - Browse repository at this point
Copy the full SHA ae842a4View commit details -
deps: disable avx512 for simutf on benchmark ci
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 98fc94a - Browse repository at this point
Copy the full SHA 98fc94aView commit details -
errors: refactor to use a method that formats a list string
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8046e0e - Browse repository at this point
Copy the full SHA 8046e0eView commit details -
src: fix creating
Isolate
s from addonsdaae938 broke addons which create their own `Isolate` instances, because enabling the shared-readonly-heap feature of V8 requires all snapshots used for different `Isolate`s to be identical. Usage of addons that do this has probably decreased quite a bit since Worker threads were introduced in Node.js, but it’s still a valid use case, and in any case the breakage was probably not intentional (although the referenced commit did require test changes because of this issue). This commit addresses this issue partially by caching the V8 snapshot parameters and ignoring ones passed in from users in `NewIsolate()` when this feature is enabled, and makes the `NodeMainInstance` snapshot-based isolate creation also re-use this code. PR-URL: #45885 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ded87f6 - Browse repository at this point
Copy the full SHA ded87f6View commit details -
meta: add
nodejs/test_runner
to CODEOWNERSPR-URL: #45935 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for e956956 - Browse repository at this point
Copy the full SHA e956956View commit details -
tools: update GitHub workflow action
Update the GitHub workflow action used for closing stalled issues and PRs. PR-URL: #45937 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1282f7f - Browse repository at this point
Copy the full SHA 1282f7fView commit details -
doc: show output of example in http
User can check output of example easily. PR-URL: #45915 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 908f4fa - Browse repository at this point
Copy the full SHA 908f4faView commit details -
meta: add
nodejs/loaders
to CODEOWNERSPR-URL: #45940 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 86e30fc - Browse repository at this point
Copy the full SHA 86e30fcView commit details -
doc: remove port from example in
url.hostname
If port is used for `url.hostname`, `url.hostname` is not working. So remove port from example in `url.hostname`. PR-URL: #45927 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4457e05 - Browse repository at this point
Copy the full SHA 4457e05View commit details -
http: improved timeout defaults handling
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ea72ee - Browse repository at this point
Copy the full SHA 7ea72eeView commit details -
net: add autoSelectFamily global getter and setter
PR-URL: #45777 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e6b8db - Browse repository at this point
Copy the full SHA 8e6b8dbView commit details -
PR-URL: #45957 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Configuration menu - View commit details
-
Copy full SHA for d8b5b7d - Browse repository at this point
Copy the full SHA d8b5b7dView commit details -
doc: update error message of example in repl
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eaf6b63 - Browse repository at this point
Copy the full SHA eaf6b63View commit details -
build: fix arm64 cross-compile from powershell
Starting vcbuild.bat for cross-compiling from powershell was failing the licensertf step because it couldn't find x64_node_exe after downloading. PR-URL: #45890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 233a66f - Browse repository at this point
Copy the full SHA 233a66fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05fee67 - Browse repository at this point
Copy the full SHA 05fee67View commit details -
buffer: add buffer.isUtf8 for utf8 validation
PR-URL: #45947 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for fbe399c - Browse repository at this point
Copy the full SHA fbe399cView commit details -
process,worker: ensure code after exit() effectless
Cope with the delay(to the next function call) of v8::Isolate::TerminateExecution() PR-URL: #45620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4c08505 - Browse repository at this point
Copy the full SHA 4c08505View commit details -
doc: replace single executable champion in strategic initiatives doc
Jesse has informed me that he won't be able to contribute to this initiative, unfortunately. If you would like to know why, feel free to ask him or me privately. I would like to take over. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45956 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71cc3b3 - Browse repository at this point
Copy the full SHA 71cc3b3View commit details -
deps: fix updater github workflow job
PR-URL: #45972 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4323f0 - Browse repository at this point
Copy the full SHA e4323f0View commit details -
test: print failed JS/parallel tests
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
Configuration menu - View commit details
-
Copy full SHA for 0f5a145 - Browse repository at this point
Copy the full SHA 0f5a145View commit details -
tools: update lint-md-dependencies to rollup@3.8.1
PR-URL: #45967 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 7c518cb - Browse repository at this point
Copy the full SHA 7c518cbView commit details -
PR-URL: #45968 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a70316 - Browse repository at this point
Copy the full SHA 0a70316View commit details -
test_runner: use os.availableParallelism()
This commit addresses an existing TODO in the code by moving to the new os.availableParallelism() instead of os.cpus().length. PR-URL: #45969 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ae24ab - Browse repository at this point
Copy the full SHA 7ae24abView commit details -
Notable changes: - Windows applications not in ConsoleMode now properly guess handle types for FILE_TYPE_CHAR file types which cannot be stat'ed. - The UVWASI_DEBUG macro can now be used without a format string. - The libuv dependency has been updated to v1.44.2. PR-URL: #45970 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e73be1b - Browse repository at this point
Copy the full SHA e73be1bView commit details -
tools: add url to
AUTHORS
update automationThis should simplify the review of `AUTHORS` file updates. PR-URL: #45971 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f968fdb - Browse repository at this point
Copy the full SHA f968fdbView commit details -
doc: make EventEmitterAsyncResource's
options
as optionalRefs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 952e03a - Browse repository at this point
Copy the full SHA 952e03aView commit details -
PR-URL: #45975 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0552b13 - Browse repository at this point
Copy the full SHA 0552b13View commit details -
src: define per-isolate internal bindings registration callback
Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db535b6 - Browse repository at this point
Copy the full SHA db535b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c5b7e6 - Browse repository at this point
Copy the full SHA 6c5b7e6View commit details -
http: replace
var
withconst
on code of comment`const` or `let` is more preferred than `var` except iteration. PR-URL: #45951 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc43922 - Browse repository at this point
Copy the full SHA bc43922View commit details -
doc: use
os.availableParallelism()
in async_context and clusterConfiguration menu - View commit details
-
Copy full SHA for 9251dce - Browse repository at this point
Copy the full SHA 9251dceView commit details -
debugger: refactor console in lib/internal/debugger/inspect.js
Configuration menu - View commit details
-
Copy full SHA for 3d09754 - Browse repository at this point
Copy the full SHA 3d09754View commit details -
src: fix crash on OnStreamRead on Windows
On Windows it's perfectly possible that the `uv_tcp_t` `read_cb` is called with an error and a null `uv_buf_t` if it corresponds to a `UV_HANDLE_ZERO_READ` read. Handle this case without crashing. Fixes: #40764 PR-URL: #45878 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 261d6d0 - Browse repository at this point
Copy the full SHA 261d6d0View commit details -
`vois` -> `void` PR-URL: #45991 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0858956 - Browse repository at this point
Copy the full SHA 0858956View commit details -
doc: fix wrong output of example in
url.protocol
Tailing slash of url.href is ommited. PR-URL: #45954 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8be1b66 - Browse repository at this point
Copy the full SHA 8be1b66View commit details -
`undefinec` -> `undefined` PR-URL: #45998 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for af25c95 - Browse repository at this point
Copy the full SHA af25c95View commit details -
esm: rewrite loader hooks test
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 2d49e0e - Browse repository at this point
Copy the full SHA 2d49e0eView commit details -
stream: refactor to use
validateFunction
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for ab22a8f - Browse repository at this point
Copy the full SHA ab22a8fView commit details -
fs: refactor to use
validateInteger
PR-URL: #46008 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 22a66cf - Browse repository at this point
Copy the full SHA 22a66cfView commit details -
doc: use console.error for error case in timers and tls
console.error is more suitable than console.log for error case. PR-URL: #46002 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 49253e1 - Browse repository at this point
Copy the full SHA 49253e1View commit details -
test: use
process.hrtime.bigint
instead ofprocess.hrtime
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2807efa - Browse repository at this point
Copy the full SHA 2807efaView commit details -
doc: sort http.createServer() options alphabetically
PR-URL: #45680 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 9e16406 - Browse repository at this point
Copy the full SHA 9e16406View commit details -
Refs: v8/v8@10.8.168.21...10.8.168.25 PR-URL: #45996 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71bf513 - Browse repository at this point
Copy the full SHA 71bf513View commit details -
lib: use
kEmptyObject
as default value for options`kEmptyObject` is more suitable than {} if options don't need mutation. PR-URL: #46011 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 28f9089 - Browse repository at this point
Copy the full SHA 28f9089View commit details -
async_hooks: refactor to use
validateObject
PR-URL: #46004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 54b748a - Browse repository at this point
Copy the full SHA 54b748aView commit details -
vm: refactor to use
validateStringArray
PR-URL: #46020 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 389cc3e - Browse repository at this point
Copy the full SHA 389cc3eView commit details -
deps: V8: cherry-pick 30861a39323d
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. R=bmeurer@chromium.org Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3 PR-URL: #45851 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fdda2ff - Browse repository at this point
Copy the full SHA fdda2ffView commit details -
events: fix violation of symbol naming convention
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 47cc0e4 - Browse repository at this point
Copy the full SHA 47cc0e4View commit details -
lib: update JSDoc of
getOwnPropertyValueOrDefault
PR-URL: #46010 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 7f1daed - Browse repository at this point
Copy the full SHA 7f1daedView commit details -
tools: add release host var to promotion script
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 54776ff - Browse repository at this point
Copy the full SHA 54776ffView commit details -
doc: update isUtf8 description
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for e113d16 - Browse repository at this point
Copy the full SHA e113d16View commit details -
tools: update doc to unist-util-select@4.0.2
PR-URL: #46038 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a8d125 - Browse repository at this point
Copy the full SHA 5a8d125View commit details -
tools: update lint-md-dependencies to rollup@3.9.0
PR-URL: #46039 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f0d22a - Browse repository at this point
Copy the full SHA 0f0d22aView commit details -
PR-URL: #46040 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 25d0a94 - Browse repository at this point
Copy the full SHA 25d0a94View commit details -
crypto: ensure exported webcrypto EC keys use uncompressed point format
Configuration menu - View commit details
-
Copy full SHA for 777c551 - Browse repository at this point
Copy the full SHA 777c551View commit details -
net: handle socket.write(cb) edge case
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4d62b09 - Browse repository at this point
Copy the full SHA 4d62b09View commit details -
2023-01-06, Version 19.4.0 (Current)
Notable changes: buffer: * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947 http: * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778 net * add autoSelectFamily global getter and setter (Paolo Insogna) #45777 os: * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895 util: * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803 PR-URL: #46061
Configuration menu - View commit details
-
Copy full SHA for e58ed6d - Browse repository at this point
Copy the full SHA e58ed6dView commit details