v16.20.0 proposal #47272
v16.20.0 proposal #47272
Conversation
PR-URL: #46037 Backport-PR-URL: #45644 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Refs: #44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44376 Backport-PR-URL: #45867 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #46677 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Original commit message:
[base] Fix build with gcc-13
See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.
Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981
Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83587}
Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`glob.glob` on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the `config.gypi` header, causing non-reproducible builds. See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out PR-URL: #44496 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
PR-URL: #45015 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
require.resolve.paths should returns null with builtin module. when builtin module without `node:` schema, `paths` returns null. But, it don't return null when builtin module with `node:` schema. Fixes: #45001 PR-URL: #45147 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Because OpenSSL v1.x doesn't do that by itself (OpenSSL v3.x does.) Fixes: #45874 PR-URL: #46185 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Avoid an endless loop if no algorithm is available to seed the cryptographically secure pseudorandom number generator (CSPRNG). Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #46237 Fixes: #46200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Refs: https://c-ares.org/changelog.html#1_19_0 PR-URL: #46415 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original commit message:
[intl] Revert date formatting behavior change from ICU 72
Replace U+202F with U+0020 after formatting date. This lets websites
continue to work without any changes.
This matches Firefox behavior, according to
https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.
Bug: chromium:1414292, chromium:1401829, chromium:1392814
Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85757}
Refs: v8/v8@90be99f
PR-URL: #46646
Refs: #46123
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #46711 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This reverts commit dee882e. Moved the test that demonstrated what this commit was fixing to the `known_issues` folder. Fixes: #46234 PR-URL: #46721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
|
Review requested:
|
Notable changes:
- deps:
- update undici to 5.20.0 (Node.js GitHub Bot)
#46711
- update c-ares to 1.19.0 (Michaël Zasso)
#46415
- upgrade npm to 8.19.4 (npm team)
#46677
- update corepack to 0.17.0 (Node.js GitHub Bot)
#46842
- (SEMVER-MINOR) src: add support for externally shared js builtins
(Michael Dawson) [#44376]
PR-URL: #47272
nodejs-github-bot
added
build
BethGriggs
force-pushed
the
v16.20.0-proposal
branch
from
bf91ceb
to
6fd13be
Compare
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
added
release
This comment was marked as outdated.
This comment was marked as outdated.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/50643/ ✅ |
|
Maybe we should include #47256 |
We'd either need to manually patch the timezone db for ICU 71.1 or update Node.js 16 to ICU 72.1 (which I'm a little hesitant about because we had issues raised about ICU 72.1 around the change to Unicode spaces -- although I think there was a V8 patch to revert (which we'd also then need to avoid breakage)). |
Even more reason not to rush, 2023b is now invalidated due to Lebanon withdrawing the change it was created to address, and users are recommended to either stick with 2023a (which we never landed in Node.js) or wait for 2023c. Refs: https://mm.icann.org/pipermail/tz/2023-March/032829.html |
|
Release build on 6fd13be: https://ci-release.nodejs.org/job/iojs+release/9239 |
I've just noticed that the aforementioned V8 patch is included in this proposal:
For the timezone updates though we'd still either need a PR explicitly for v16.x-staging against ICU 71.1 or another PR to main either downgrading to tz 2023a, or waiting and then updating to 2023c (unicode-org/icu-data#36) and landing ICU 72.1 and the tz update together. I don't think we should delay this release for either of those options. If anyone reads this and needs updated timezone information, a workaround is to locally download the updated |
Notable changes:
- deps:
- update undici to 5.20.0 (Node.js GitHub Bot)
#46711
- update c-ares to 1.19.0 (Michaël Zasso)
#46415
- upgrade npm to 8.19.4 (npm team)
#46677
- update corepack to 0.17.0 (Node.js GitHub Bot)
#46842
- (SEMVER-MINOR) src: add support for externally shared js builtins
(Michael Dawson) [#44376]
PR-URL: #47272
2023-03-29, Version 16.20.0 'Gallium' (LTS), @BethGriggs
Notable Changes
Commits
de6dd67790] - crypto: avoid hang when no algorithm available (Richard Lau) #462374617512788] - crypto: ensure auth tag set for chacha20-poly1305 (Ben Noordhuis) #4618524972164fc] - deps: update undici to 5.20.0 (Node.js GitHub Bot) #4671185f88c6a8d] - deps: V8: cherry-pick 90be99fab31c (Michaël Zasso) #46646b4ebe6d47b] - deps: update c-ares to 1.19.0 (Michaël Zasso) #4641556cbc7fdda] - deps: V8: cherry-pick c2792e58035f (Jiawen Geng) #449617af9bdb31e] - deps: upgrade npm to 8.19.4 (npm team) #46677962a7471b5] - deps: update corepack to 0.17.0 (Node.js GitHub Bot) #46842748bc96e35] - deps: update corepack to 0.16.0 (Node.js GitHub Bot) #46710a467782499] - deps: update corepack to 0.15.3 (Node.js GitHub Bot) #460371913b6763d] - deps: update corepack to 0.15.2 (Node.js GitHub Bot) #45635809371a15f] - module: require.resolve.paths returns null with node schema (MURAKAMI Masahiko) #45147086bb2f8d4] - Revert "src: let http2 streams end after session close" (Rich Trott) #467216a01d39120] - (SEMVER-MINOR) src: add support for externally shared js builtins (Michael Dawson) #44376d081032a60] - test: fix test-net-connect-reset-until-connected (Vita Batrla) #46781efe1be47ec] - test: skip test depending onoverlapped-checkerwhen not available (Antoine du Hamel) #45015fc47d58abe] - test: remove cjs loader from stack traces (Geoffrey Booth) #44197cf76d0790d] - test: fix WPT title when no META title is present (Filip Skokan) #468040d1485b924] - test: fix default WPT titles (Filip Skokan) #46778088e9cde3d] - test: add WPTRunner support for variants and generating WPT reports (Filip Skokan) #46498908c4dff44] - test: mark test-crypto-key-objects flaky on Linux (Richard Lau) #46684768e56227e] - tools: makeutils.SearchFilesdeterministic (Bruno Pitrus) #44496