48198 node api external strings #48339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
gabrielschulhof
changed the title
gabrielschulhof
commented
Jun 5, 2023
src/js_native_api_v8.cc
Outdated
|
|
||
| napi_status NAPI_CDECL node_api_create_external_string_utf16( | ||
| napi_env env, const char16_t* str, size_t length, napi_value* result) { | ||
| #if defined(V8_ENABLE_SANDBOX) |
There was a problem hiding this comment.
Check with Electron if this is needed for strings.
gabrielschulhof
commented
Jun 5, 2023
src/js_native_api_v8.cc
Outdated
| class ExternalOneByteStringResource | ||
| : public v8::String::ExternalOneByteStringResource { | ||
| public: | ||
| ExternalOneByteStringResource(const char* string, const size_t length) |
There was a problem hiding this comment.
Is it OK if lengh is NAPI_AUTO_LENGTH?
There was a problem hiding this comment.
Chose to assume that it is not, and used C++ string view to compute length.
daeyeon
reviewed
Jun 5, 2023
gabrielschulhof
force-pushed
the
48198-node-api-external-strings
branch
from
cf6e959
to
20ab0fb
Compare
gabrielschulhof
commented
Jun 8, 2023
gabrielschulhof
changed the title
daeyeon
reviewed
Jun 8, 2023
Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
gabrielschulhof
commented
Jun 11, 2023
daeyeon
reviewed
Jun 12, 2023
Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
approved these changes
Jun 12, 2023
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
This was referenced Jun 13, 2023
gabrielschulhof
added a commit
that referenced
this pull request
Jun 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
|
Landed in 60d9aed. |
This was referenced Jun 15, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: nodejs#48339 Fixes: nodejs#48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: nodejs#48339 Fixes: nodejs#48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 8, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.