Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove --no-warnings flag in test_runner fixtures #48989

Merged
merged 1 commit into from
Aug 3, 2023
Merged

test: remove --no-warnings flag in test_runner fixtures #48989

merged 1 commit into from
Aug 3, 2023

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Aug 1, 2023

no longer needed after #48915 fix

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 1, 2023
MoLow
MoLow approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53038/

@rluvaton
Copy link
Member Author

rluvaton commented Aug 2, 2023

Seems unrelated can you please retry?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53051/

@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Open
29 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53056/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1353681 into nodejs:main Aug 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1353681

@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Open
25 tasks
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
931dd52 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
6c8b82b 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: remove --no-warnings flag in test_runner fixtures
caed781 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: remove --no-warnings flag in test_runner fixtures
a757158 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@rluvaton @UlisesGascon
test: remove --no-warnings flag in test_runner fixtures
d968618 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test: remove --no-warnings flag in test_runner fixtures
be56e23 
no longer needed after #48915 fix

PR-URL: #48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test: remove --no-warnings flag in test_runner fixtures
9e0d82a 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
dd1f1f4 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Aug 17, 2023
@RafaelGSS
Copy link
Member

Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

@rluvaton rluvaton deleted the remove-no-warning-in-test-output branch August 17, 2023 22:25
@rluvaton rluvaton mentioned this pull request Aug 18, 2023
Closed
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 18, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
33f2969 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@rluvaton rluvaton added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Aug 18, 2023
@rluvaton
Copy link
Member Author

Backport PR:

rluvaton added a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
dbc3124 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@rluvaton @UlisesGascon
test: remove --no-warnings flag in test_runner fixtures
4d184b5 
no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
@targos targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Nov 12, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
@rluvaton @targos
test: remove --no-warnings flag in test_runner fixtures
7e714e6 
no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: remove --no-warnings flag in test_runner fixtures
1b442df 
no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: remove --no-warnings flag in test_runner fixtures
b52c472 
no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
backported-to-v20.x PRs backported to the v20.x-staging branch. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rluvaton @nodejs-github-bot @RafaelGSS @MoLow @atlowChemi @targos