test_runner: fix global before not called when no global test exists

[rluvaton]

fix #48844

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[rluvaton]

because of #48867 we must use process.exit as otherwise, it won't fail the test

[rluvaton]

it seems really weird that we executing top describe afterEach before the nested one...

[rluvaton]

I see #48736 (comment) also talked about afterEach...

[atlowChemi]

If we reach here this.parent will have a value (and we already call runHook without the optional chaining)

Suggested change

	await this.parent.runHook('before', this.parent?.getRunArgs());
	await this.parent.runHook('before', this.parent.getRunArgs());

[MoLow]

I would expect this to replace the call to this.runHook('before', hookArgs);, and also for the same implementation for beforeEach, afterEach and after

[rluvaton]

We can't for after as if there are multiple describe we only need to run for the last one after all test completes

[rluvaton]

Why did you expect that? Current describe hooks have different hookArgs that the parent (which I think is why some tests are failing when I run with the current tests args)

[MoLow]

I guess It is just surprising that the before and after hooks are not "symmetric"

[rluvaton]

It is, the first describe should run the before and the last describe should run the after...

[MoLow]

I would simply expect to also see this.parent.runHook('after') - but I guess I am missing something

[rluvaton]

let's take this test for example:

const {describe, it, before, after} = require("node:test");


describe('top desc', () => {
  before(() => {
    console.log('before top desc');
  });

  after(() => {
    console.log('after top desc');
  });

  describe('inner describe 1', () => {
    before(() => {
      console.log('before inner 1 desc');
    });

    after(() => {
      console.log('after inner 1 desc');
    });

    it('inner it 1', () => {
      console.log('inner it 1');
    });
  });

  describe('inner describe 2', () => {
    before(() => {
      console.log('before inner 2 desc');
    });

    after(() => {
      console.log('after inner 2 desc');
    });

    it('inner it 1', () => {
      console.log('inner it 2');
    });
  });
});

the expected log is:

before top desc
before inner 1 desc
inner it 1
after inner 1 desc
before inner 2 desc
inner it 2
after inner 2 desc
after top desc <-----

if I add this.parent.runHook('after') as well the output will be:

before top desc
before inner 1 desc
inner it 1
after top desc <-----
after inner 1 desc
before inner 2 desc
inner it 2
after inner 2 desc

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52912/

[MoLow]

LGTM. I think afterEach and beforeEach might need the same fix, but that can be handled by another PR

[rluvaton]

There is no need as we concat the before and after each in the constructor

[nodejs-github-bot]

Landed in a0f3ed8

[RafaelGSS]

This commit didn't land cleanly on v20.x-staging. Could you please open a manual backport? Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

[rluvaton]

Backport PR:

• [v20.x backport] backport multiple test runner related prs #49225