test_runner: reland run global after() hook earlier #49116

cjihrig · 2023-08-12T14:18:13Z

This commit reverts the revert in
bb52656. It also includes the fix for the issue that required the revert
(#49059 (comment)) and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110

nodejs-github-bot · 2023-08-12T14:18:18Z

Review requested:

@nodejs/test_runner

mcollina

lgtm

nodejs-github-bot · 2023-08-12T17:45:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53242/

nodejs-github-bot · 2023-08-12T19:03:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53243/

nodejs-github-bot · 2023-08-12T19:51:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53248/

nodejs-github-bot · 2023-08-12T20:35:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53250/ 🟡

rluvaton · 2023-08-13T10:05:45Z

lib/internal/test_runner/harness.js

-  const exitHandler = async () => {
-    await root.run(new ERR_TEST_FAILURE(
+  const exitHandler = () => {
+    root.postRun(new ERR_TEST_FAILURE(


why not await?

@rluvaton postRun returns void (and not a Promise)

I thought I changed that (or I'm thinking of another function there) 😅

nodejs-github-bot · 2023-08-14T14:29:30Z

Landed in b574075

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

RafaelGSS · 2023-08-17T19:12:09Z

Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

rluvaton · 2023-08-18T10:08:41Z

Backport PR:

[v20.x backport] backport multiple test runner related prs #49225

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Backport-PR-URL: #49225 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656fc627e4f48a0f706756873b593d81372a. It also includes the fix for the issue that required the revert (nodejs/node#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs/node#49059 Refs: nodejs/node#49110 PR-URL: nodejs/node#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

test_runner: reland run global after() hook earlier

6796570

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110

cjihrig requested review from mcollina, benjamingr, MoLow and atlowChemi August 12, 2023 14:18

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 12, 2023

mcollina approved these changes Aug 12, 2023

View reviewed changes

atlowChemi approved these changes Aug 12, 2023

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2023

MoLow approved these changes Aug 12, 2023

View reviewed changes

github-actions bot mentioned this pull request Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

29 tasks

cjihrig removed the needs-ci PRs that need a full CI run. label Aug 13, 2023

benjamingr approved these changes Aug 13, 2023

View reviewed changes

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023

rluvaton reviewed Aug 13, 2023

View reviewed changes

github-actions bot mentioned this pull request Aug 14, 2023

CI Reliability 2023-08-14 nodejs/reliability#636

Open

25 tasks

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2023

nodejs-github-bot merged commit b574075 into nodejs:main Aug 14, 2023
37 checks passed

github-actions bot mentioned this pull request Aug 15, 2023

CI Reliability 2023-08-15 nodejs/reliability#637

Open

22 tasks

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

cjihrig deleted the reland branch August 17, 2023 16:52

RafaelGSS added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Aug 17, 2023

rluvaton mentioned this pull request Aug 18, 2023

[v20.x backport] backport multiple test runner related prs #49225

Closed

rluvaton added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Aug 18, 2023

UlisesGascon mentioned this pull request Sep 10, 2023

v20.7.0 proposal #49592

Merged

targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Nov 12, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_runner: reland run global after() hook earlier #49116

test_runner: reland run global after() hook earlier #49116

cjihrig commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

mcollina left a comment

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023 •

edited by cjihrig

Loading

rluvaton Aug 13, 2023

atlowChemi Aug 13, 2023

rluvaton Aug 13, 2023

nodejs-github-bot commented Aug 14, 2023

RafaelGSS commented Aug 17, 2023

rluvaton commented Aug 18, 2023

test_runner: reland run global after() hook earlier #49116

test_runner: reland run global after() hook earlier #49116

Conversation

cjihrig commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023 • edited by cjihrig Loading

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

atlowChemi Aug 13, 2023

Choose a reason for hiding this comment

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 14, 2023

RafaelGSS commented Aug 17, 2023

rluvaton commented Aug 18, 2023

nodejs-github-bot commented Aug 12, 2023 •

edited by cjihrig

Loading