Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test_runner: run global after() hook earlier" #49110

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Revert "test_runner: run global after() hook earlier" #49110

merged 1 commit into from
Aug 12, 2023

Conversation

joyeecheung
Copy link
Member

This reverts commit 6346bdc.

Reason for revert: breaking CI

See https://ci.nodejs.org/job/node-test-pull-request/53201/ and https://ci.nodejs.org/job/node-test-pull-request/53200/ where test-runner-output.mjs failed everywhere, though the changes are unrelated. This test also fails for me locally consistently unless I revert #49059

@joyeecheung
Revert "test_runner: run global after() hook earlier"
b603fb6 
This reverts commit 6346bdc.

Reason for revert: breaking CI
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 11, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@richardlau richardlau mentioned this pull request Aug 11, 2023
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53206/

@anonrig anonrig mentioned this pull request Aug 11, 2023
Merged
11 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49110
✔  Done loading data for nodejs/node/pull/49110
----------------------------------- PR info ------------------------------------
Title      Revert "test_runner: run global after() hook earlier" (#49110)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:revert-49059 -> nodejs:main
Labels     fast-track, author ready, needs-ci, test_runner
Commits    1
 - Revert "test_runner: run global after() hook earlier"
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49110
Reviewed-By: Colin Ihrig 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49110
Reviewed-By: Colin Ihrig 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 11 Aug 2023 16:53:34 GMT
   ✔  Approvals: 6
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574075155
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574080138
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574115646
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574118355
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574121762
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574230036
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-08-11T17:55:23Z: https://ci.nodejs.org/job/node-test-pull-request/53206/
- Querying data for job/node-test-pull-request/53206/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5838544157

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit bb52656 into nodejs:main Aug 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in bb52656

cjihrig added a commit to cjihrig/node that referenced this pull request Aug 12, 2023
@cjihrig
test_runner: reland run global after() hook earlier
6796570 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
@cjihrig cjihrig mentioned this pull request Aug 12, 2023
Merged
martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@joyeecheung @martenrichter
Revert "test_runner: run global after() hook earlier"
6b98fbb 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: nodejs#49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 14, 2023
@cjihrig
test_runner: reland run global after() hook earlier
b574075 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@joyeecheung @Ceres6
Revert "test_runner: run global after() hook earlier"
6881a8b 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: nodejs#49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@joyeecheung @Ceres6
Revert "test_runner: run global after() hook earlier"
1b771e5 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: nodejs#49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
test_runner: reland run global after() hook earlier
1373b69 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@joyeecheung @RafaelGSS
Revert "test_runner: run global after() hook earlier"
e3cb373 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: #49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
adab698 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
@joyeecheung joyeecheung mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@joyeecheung @RafaelGSS
Revert "test_runner: run global after() hook earlier"
50feedc 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: nodejs#49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
b9407ff 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@joyeecheung @rluvaton
Revert "test_runner: run global after() hook earlier"
21f58cc 
This reverts commit 6346bdc.

Reason for revert: breaking CI

PR-URL: nodejs#49110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@cjihrig @rluvaton
test_runner: reland run global after() hook earlier
23fce71 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Aug 16, 2023
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
324c8a1 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 18, 2023
@cjihrig @rluvaton
test_runner: reland run global after() hook earlier
5f893ac 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@cjihrig @rluvaton
test_runner: reland run global after() hook earlier
2ad1bbc 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@cjihrig @UlisesGascon
test_runner: reland run global after() hook earlier
546ad5f 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Backport-PR-URL: #49225
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@cjihrig @targos
test_runner: reland run global after() hook earlier
d839640 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: reland run global after() hook earlier
7b5134a 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: reland run global after() hook earlier
b4224c7 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@debadree25 debadree25 debadree25 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@joyeecheung @nodejs-github-bot @benjamingr @lpinca @anonrig @cjihrig @debadree25 @LiviaMedeiros @GeoffreyBooth @aduh95