build: fix typo libray -> library (configure.py)
#49106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
richardlau
approved these changes
Aug 11, 2023
Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
michalbiesek
force-pushed
the
build-fix-typo
branch
from
6b2d04c
to
4ea89c7
Compare
deokjinkim
changed the title
libray -> library (configure.py)libray -> library (configure.py)
deokjinkim
approved these changes
Aug 11, 2023
richardlau
added
author ready
github-actions
bot
removed
the
request-ci
|
Test failure is #49059 (comment), being fixed (🤞) by a revert #49110. |
benjamingr
approved these changes
Aug 11, 2023
lpinca
approved these changes
Aug 11, 2023
29 tasks
22 tasks
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b3eb05b |
This was referenced Aug 16, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Signed-off-by: Michal Biesek <michalbiesek@gmail.com> PR-URL: #49106 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Michal Biesek <michalbiesek@gmail.com> PR-URL: #49106 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Michal Biesek <michalbiesek@gmail.com> PR-URL: nodejs/node#49106 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Michal Biesek <michalbiesek@gmail.com> PR-URL: nodejs/node#49106 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.