Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tmpdir.resolve() #49079

Merged
merged 1 commit into from
Aug 13, 2023
Merged

test: add tmpdir.resolve() #49079

merged 1 commit into from
Aug 13, 2023

Conversation

LiviaMedeiros
Copy link
Contributor

Adds a simple method to make the usual routine of path.join(tmpdir.path, ...) more concise and avoid unnecessary import from node:path almost every time tmpdir is used.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 9, 2023
@LiviaMedeiros LiviaMedeiros force-pushed the test-ft-tmpdir-resolve branch from 550ddaf to 8d0bc39 Compare August 10, 2023 12:30
@aduh95
Copy link
Contributor

aduh95 commented Aug 11, 2023

It's a lot of files to review, and you are going to end up in a conflict hell. Maybe we can split this into several PRs?

@LiviaMedeiros LiviaMedeiros force-pushed the test-ft-tmpdir-resolve branch from 8d0bc39 to 3d3cc33 Compare August 11, 2023 15:14
@LiviaMedeiros
Copy link
Contributor Author

Sure, I'll try to split test changes by subsystems after landing this one.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@LiviaMedeiros LiviaMedeiros force-pushed the test-ft-tmpdir-resolve branch from 3d3cc33 to c59cc3e Compare August 12, 2023 06:49
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53236/

@github-actions github-actions bot mentioned this pull request Aug 13, 2023
Open
29 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit a4928b0 into nodejs:main Aug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a4928b0

This was referenced Aug 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Open
25 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@LiviaMedeiros @Ceres6
test: add tmpdir.resolve()
5f8de81 
PR-URL: nodejs#49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Open
22 tasks
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.resolve()
2da3221 
PR-URL: #49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.resolve()
ea9d1e0 
PR-URL: nodejs#49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@LiviaMedeiros @rluvaton
test: add tmpdir.resolve()
f70d525 
PR-URL: nodejs#49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.resolve()
ca737b4 
PR-URL: #49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.resolve()
13bd7a0 
PR-URL: #49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 30, 2023
@LiviaMedeiros
benchmark: use tmpdir.resolve()
fcf5de0 
PR-URL: #49137
Refs: #49079
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@LiviaMedeiros @UlisesGascon
benchmark: use tmpdir.resolve()
e845155 
PR-URL: #49137
Refs: #49079
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 28, 2023
@LiviaMedeiros @richardlau
test: add tmpdir.resolve()
04cba95 
PR-URL: #49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Oct 6, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@LiviaMedeiros @alexfernandez
benchmark: use tmpdir.resolve()
2951b2e 
PR-URL: nodejs#49137
Refs: nodejs#49079
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiviaMedeiros @aduh95 @nodejs-github-bot @joyeecheung