Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use tmpdir.resolve() in various tests #3 #49136

Merged
merged 1 commit into from
Aug 21, 2023
Merged

test: use tmpdir.resolve() in various tests #3 #49136

merged 1 commit into from
Aug 21, 2023

Conversation

LiviaMedeiros
Copy link
Contributor

Extracted from: #49079

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. report Issues and PRs related to process.report. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Aug 13, 2023
@LiviaMedeiros LiviaMedeiros removed doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. node-api Issues and PRs related to the Node-API. esm Issues and PRs related to the ECMAScript Modules implementation. report Issues and PRs related to process.report. labels Aug 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53371/

@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Open
26 tasks
@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2023
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Open
32 tasks
@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 052434a into nodejs:main Aug 21, 2023
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 052434a

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@LiviaMedeiros @UlisesGascon
test: use tmpdir.resolve()
e391f4b 
PR-URL: #49136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiviaMedeiros @nodejs-github-bot @lpinca