Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use internal pathToFileURL #49553

Merged
merged 1 commit into from
Sep 10, 2023
Merged

lib: use internal pathToFileURL #49553

merged 1 commit into from
Sep 10, 2023

Conversation

LiviaMedeiros
Copy link
Contributor

For internal usage, internal/url version should be used instead of re-exported url.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. labels Sep 8, 2023
aduh95
aduh95 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should forbid to require('url)` from internal code

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53810/

@LiviaMedeiros
Copy link
Contributor Author

Yes, perhaps. I'll look into other require('url') usages later.

deokjinkim added a commit to deokjinkim/node that referenced this pull request Sep 8, 2023
@deokjinkim
lib: use internal fileURLToPath
2fea2ec 
For internal usage, `internal/url` should be used.

Refs: nodejs#49553
@deokjinkim deokjinkim mentioned this pull request Sep 8, 2023
Merged
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit afea87e into nodejs:main Sep 10, 2023
40 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in afea87e

@LiviaMedeiros LiviaMedeiros mentioned this pull request Sep 10, 2023
Closed
nodejs-github-bot pushed a commit that referenced this pull request Sep 10, 2023
@deokjinkim
lib: use internal fileURLToPath
b3fc917 
For internal usage, `internal/url` should be used.

Refs: #49553
PR-URL: #49558
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@LiviaMedeiros @ruyadorno
lib: use internal pathToFileURL
e515046 
PR-URL: #49553
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@deokjinkim @ruyadorno
lib: use internal fileURLToPath
f62d649 
For internal usage, `internal/url` should be used.

Refs: #49553
PR-URL: #49558
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@LiviaMedeiros @alexfernandez
lib: use internal pathToFileURL
d457661 
PR-URL: nodejs#49553
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@deokjinkim @alexfernandez
lib: use internal fileURLToPath
d67aefd 
For internal usage, `internal/url` should be used.

Refs: nodejs#49553
PR-URL: nodejs#49558
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiviaMedeiros @nodejs-github-bot @JakobJingleheimer @aduh95