lib: use internal fileURLToPath
#49558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For internal usage, `internal/url` should be used. Refs: nodejs#49553
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Sep 8, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
rluvaton
approved these changes
Sep 8, 2023
24 tasks
atlowChemi
approved these changes
Sep 9, 2023
19 tasks
LiviaMedeiros
approved these changes
Sep 10, 2023
anonrig
approved these changes
Sep 10, 2023
anonrig
added
the
commit-queue
JungMinu
approved these changes
Sep 10, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in b3fc917 |
This was referenced Sep 11, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
For internal usage, `internal/url` should be used. Refs: #49553 PR-URL: #49558 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
For internal usage, `internal/url` should be used. Refs: nodejs#49553 PR-URL: nodejs#49558 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal usage,
internal/urlshould be used.Refs: #49553