Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: reduce overhead of new user timings #49914

Merged
merged 2 commits into from
Oct 5, 2023
Merged

perf_hooks: reduce overhead of new user timings #49914

merged 2 commits into from
Oct 5, 2023

Conversation

H4ad
Copy link
Member

@H4ad H4ad commented Sep 28, 2023 •
edited
Loading

Continuing the work started on nodejs/performance#109.

This PR should be landed after #49837.

                                                    confidence improvement accuracy (*)    (**)   (***)
perf_hooks/usertiming.js observe='all' n=100000            ***    351.28 %       ±9.79% ±13.17% ±17.46%
perf_hooks/usertiming.js observe='measure' n=100000        ***    436.41 %       ±8.94% ±12.03% ±15.93%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 2 comparisons, you can thus
expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

I will use the changes on the latest PR to keep this even simpler, so I will keep as draft for now.

cc @nodejs/performance

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 28, 2023
@H4ad H4ad force-pushed the perf/perf_hooks_usertiming branch from f6ff458 to 5fd5fad Compare October 1, 2023 14:29
@H4ad H4ad marked this pull request as ready for review October 1, 2023 14:30
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54443/

benjamingr
benjamingr approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj

@H4ad H4ad force-pushed the perf/perf_hooks_usertiming branch from df6db01 to 41a0fdf Compare October 1, 2023 16:16
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Open
12 tasks
@anonrig anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54466/

@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54515/

@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54518/

@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54554/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0e507d3 into nodejs:main Oct 5, 2023
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0e507d3

@H4ad H4ad deleted the perf/perf_hooks_usertiming branch October 5, 2023 11:28
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@H4ad @alexfernandez
perf_hooks: reduce overhead of new user timings
1f61aa4 
PR-URL: nodejs#49914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@H4ad @targos
perf_hooks: reduce overhead of new user timings
e8f024b 
PR-URL: #49914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@H4ad @debadree25
perf_hooks: reduce overhead of new user timings
7665ea7 
PR-URL: nodejs#49914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@sheplu sheplu sheplu approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@H4ad @nodejs-github-bot @Qard @sheplu @benjamingr @anonrig