Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-runner-watch-mode #49997

Closed
wants to merge 1 commit into from
Closed

test: deflake test-runner-watch-mode #49997

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 1, 2023

Fixes: #49985

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 1, 2023
@MoLow
Copy link
Member Author

MoLow commented Oct 1, 2023

stress test: https://ci.nodejs.org/view/All/job/node-stress-single-test/452/

cjihrig
cjihrig approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the stress test passes.

@MoLow
Copy link
Member Author

MoLow commented Oct 2, 2023

Stress test passed

@MoLow MoLow marked this pull request as ready for review October 2, 2023 06:11
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54457/

@MoLow
Copy link
Member Author

MoLow commented Oct 2, 2023

didnt seem to solve the issue

@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Open
18 tasks
This was referenced Oct 4, 2023
Open
Open
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 17, 2023
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig
Copy link
Member

anonrig commented Oct 18, 2023

didnt seem to solve the issue

Is this still the case @MoLow?

This was referenced Oct 19, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55289/

@RedYetiDev
Copy link
Member

RedYetiDev commented Apr 23, 2024 •
edited
Loading

Hi! It's been a while since any activity on this PR, but it has several approvals. This comment will bump it to the front of the PR page so more people can see (and implement) this change.

If you still want to pursue this, please make sure that this change is still relevant.

This comment is an attempt to resolve older pull requests.

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/505/

@MoLow MoLow closed this May 24, 2024
@MoLow MoLow deleted the deflake-test-runner-watch-mode branch May 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel.test-runner-watch-mode is flaky
9 participants
@MoLow @nodejs-github-bot @anonrig @RedYetiDev @aduh95 @lpinca @cjihrig @StefanStojanovic @atlowChemi