Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set test-runner-watch-mode as flaky #50221

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test: set test-runner-watch-mode as flaky #50221

merged 1 commit into from
Oct 18, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 17, 2023

Ref: #49985

cc @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 17, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54907/

@GeoffreyBooth
Copy link
Member

But #49997 is open to fix this.

@anonrig
Copy link
Member Author

anonrig commented Oct 17, 2023

But #49997 is open to fix this.

@MoLow responded and said that the pr didn't fix the issue. Ref: #49997 (comment)

@anonrig anonrig requested a review from jasnell October 18, 2023 01:03
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54916/

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit aa8282e into nodejs:main Oct 18, 2023
38 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in aa8282e

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
8efb75f 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set test-runner-watch-mode as flaky
0102327 
PR-URL: nodejs#50221
Refs: nodejs#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
c2c2506 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
5953a25 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
dccc650 
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
530add0 
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@MoLow MoLow Awaiting requested review from MoLow

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @GeoffreyBooth @mcollina @cjihrig @ronag