-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: add undici websocket benchmark #50586
Conversation
There is a typo in a commit message ("benchamrk" -> "benchmark") but I think we will squash commits so it does not matter. |
@lpinca I noticed that you have approved this PR for three weeks now, but it has not been merged yet. Is it still waiting for approval from other reviewers? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I've been very busy the last few weeks.
Commit Queue failed- Loading data for nodejs/node/pull/50586 ✔ Done loading data for nodejs/node/pull/50586 ----------------------------------- PR info ------------------------------------ Title benchmark: add undici websocket benchmark (#50586) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch chenyuyang2022:ws-bench -> nodejs:main Labels benchmark, commit-queue-squash Commits 8 - benchmark: add undici websocket benchmark - benchmark: update websocket server - benchmark: update undici benchmark - benchamrk: update undici websocket benchmark - test: add test/benchmark/test-benchmark-websocket.js - update undici websocket benchmark & test - fix lint error - update undici websocket benchmark Committers 1 - Chenyu Yang PR-URL: https://github.com/nodejs/node/pull/50586 Refs: https://github.com/nodejs/performance/issues/114 Reviewed-By: Luigi Pinca Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50586 Refs: https://github.com/nodejs/performance/issues/114 Reviewed-By: Luigi Pinca Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Nov 2023 03:49:19 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50586#pullrequestreview-1729891063 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/50586#pullrequestreview-1765869891 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7105461887 |
Landed in 212a972 |
Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Refs: nodejs/performance#114
I added a simple benchmark for the undici websocket. I modified the client in https://github.com/websockets/ws/blob/master/bench/speed.js to use undici instead.
Platform
Linux benchmark-S2600WFT 5.15.0-41-generic #44-Ubuntu SMP Wed Jun 22 14:20:53 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
20.x vs 21.x